New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] [NFR] - Add Base 62 to Phalcon\Security\Random #12105

Closed
dschissler opened this Issue Aug 7, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@dschissler
Contributor

dschissler commented Aug 7, 2016

Base62 is nice because it is the largest value that can safely be used in URLs without needing to take extra characters into consideration because it is [A-Za-z0-9].

@sergeyklay sergeyklay added this to the 3.1.0 milestone Aug 12, 2016

@sergeyklay sergeyklay self-assigned this Aug 12, 2016

@dschissler

This comment has been minimized.

Show comment
Hide comment
@dschissler

dschissler Dec 7, 2016

Contributor

Also base 62 can be made to handle negative numbers as well since the - symbol is unused. I'm unsure if we would want to add negative number handling to the routines or just to leave it up to the developer if they need it.

Actually I'd like to see Phalcon be able to provide a nice API wrapper for creating numbers in various bases because the gmp_strval(gmp_init(...)) (using gmp extension) approach really sucks.

Also, wow, it would be nice if Phalcon could generate some UUIDs as well because that whole situation in PHP is a huge joke and it takes up far too much time for such an ancient concept.

Contributor

dschissler commented Dec 7, 2016

Also base 62 can be made to handle negative numbers as well since the - symbol is unused. I'm unsure if we would want to add negative number handling to the routines or just to leave it up to the developer if they need it.

Actually I'd like to see Phalcon be able to provide a nice API wrapper for creating numbers in various bases because the gmp_strval(gmp_init(...)) (using gmp extension) approach really sucks.

Also, wow, it would be nice if Phalcon could generate some UUIDs as well because that whole situation in PHP is a huge joke and it takes up far too much time for such an ancient concept.

@sergeyklay sergeyklay modified the milestones: 3.1.0, 3.2.0 Mar 2, 2017

@sergeyklay sergeyklay referenced this issue May 21, 2017

Merged

Added Phalcon\Security\Random:base62 #12858

3 of 3 tasks complete
@sergeyklay

This comment has been minimized.

Show comment
Hide comment
@sergeyklay

sergeyklay May 21, 2017

Member

Implemented in the 3.2.x branch

Member

sergeyklay commented May 21, 2017

Implemented in the 3.2.x branch

@sergeyklay sergeyklay closed this May 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment