New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFR] Add type time to column types #12223

Closed
ruudboon opened this Issue Sep 15, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@ruudboon
Copy link
Member

ruudboon commented Sep 15, 2016

class Phalcon\Db\Column implements ColumnInterface
{
    const TYPE_INTEGER = 0;
    const TYPE_DATE = 1;
    const TYPE_VARCHAR = 2;
    const TYPE_DECIMAL = 3;
    const TYPE_DATETIME = 4;
    const TYPE_CHAR = 5;
    const TYPE_TEXT = 6;
    const TYPE_FLOAT = 7;
    const TYPE_BOOLEAN = 8;
    const TYPE_DOUBLE = 9;
    const TYPE_TINYBLOB = 10;
    const TYPE_BLOB = 11;
    const TYPE_MEDIUMBLOB = 12;
    const TYPE_LONGBLOB = 13;
    const TYPE_BIGINTEGER = 14;
    const TYPE_JSON = 15;
    const TYPE_JSONB = 16;
    const TYPE_TIMESTAMP = 17;
}

Currently the type time is missing from Phalcon\Db\Column causing issues when doing migration with the phalcon dev tools when having a mysql time field in place. Would be great if we can add this type so we can solve this related issue: phalcon/phalcon-devtools#308

@sergeyklay sergeyklay added this to the 4.0.0 milestone Sep 4, 2017

@sergeyklay sergeyklay changed the title Add type time to column types [NFR] Add type time to column types Sep 4, 2017

@stale

This comment has been minimized.

Copy link

stale bot commented Apr 16, 2018

Thank you for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please feel free to either reopen this issue or open a new one. We will be more than happy to look at it again! You can read more here: https://blog.phalconphp.com/post/github-closing-old-issues

@stale stale bot added the stale label Apr 16, 2018

@sergeyklay sergeyklay closed this Apr 16, 2018

@sergeyklay sergeyklay reopened this May 2, 2018

@stale stale bot removed the stale label May 2, 2018

@ruudboon

This comment has been minimized.

Copy link
Member Author

ruudboon commented May 2, 2018

Great to see this reopened!

@niden niden referenced this issue Oct 31, 2018

Merged

[#13543] Add more pdo types #13562

3 of 3 tasks complete
@niden

This comment has been minimized.

Copy link
Member

niden commented Oct 31, 2018

@niden niden closed this Oct 31, 2018

@niden niden referenced this issue Oct 31, 2018

Open

Update 4.x Documents #1935

0 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment