New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container interface (PSR-11) #12295

Open
sergeyklay opened this Issue Oct 6, 2016 · 7 comments

Comments

Projects
None yet
6 participants
@sergeyklay
Member

sergeyklay commented Oct 6, 2016

Phalcon's DI must be fully compatible with Container interface (PSR-11) for v4.0.0


Refs:

@sergeyklay sergeyklay added this to the 4.0.0 milestone Oct 6, 2016

@virgofx

This comment has been minimized.

Member

virgofx commented Oct 6, 2016

How would this be implemented? Create similar container interface or would Phalcon somehow import/reference Psr* packages?

@sergeyklay

This comment has been minimized.

Member

sergeyklay commented Oct 6, 2016

I need to research best way

@Jurigag

This comment has been minimized.

Member

Jurigag commented Oct 6, 2016

@virgofx the same question is for psr request i guess

@sergeyklay sergeyklay added the RFC label Oct 6, 2016

@SidRoberts

This comment has been minimized.

Member

SidRoberts commented Oct 7, 2016

I personally find this PSR a bit vague (it only has two methods) so I don't think it's absolutely essential that Phalcon should actually implement the interface. I think just following the spec should be enough.

Two things I'd like to recommend:

@stale

This comment has been minimized.

stale bot commented Apr 16, 2018

Thank you for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please feel free to either reopen this issue or open a new one. We will be more than happy to look at it again! You can read more here: https://blog.phalconphp.com/post/github-closing-old-issues

@stale stale bot added the stale label Apr 16, 2018

@sergeyklay sergeyklay closed this Apr 16, 2018

@sergeyklay sergeyklay reopened this May 2, 2018

@stale stale bot removed the stale label May 2, 2018

@sergeyklay sergeyklay changed the title from [NFR] Container Interface to Container interface (PSR-11) Jul 16, 2018

@sergeyklay

This comment has been minimized.

Member

sergeyklay commented Jul 16, 2018

@dragoonis Just assigned to you.

@sergeyklay sergeyklay referenced this issue Jul 16, 2018

Closed

Create ROADMAP-4.0.md #13432

3 of 3 tasks complete
@Idrinth

This comment has been minimized.

Idrinth commented Aug 29, 2018

would likely be easiest for users if phalcon would just contain the psr-interfaces - having a similar one is not really going to help out much, since their implementations and the interfaces themselves would not be easily exchangeable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment