Acl default access

[Jurigag]

Expected and Actual Behavior

Currently when using setDefaultAccess in Phalcon\Acl\Adapter\Memory and then adding roles it's adding such an access:

let this->_access[roleName . "!*!*"] = this->_defaultAccess;

Since the memory adapter is just stopping when hit any key, it will first hit this key and ignore any other allow rules we will set. I think we can safely remove this line https://github.com/phalcon/cphalcon/blob/master/phalcon/acl/adapter/memory.zep#L210 and let this line https://github.com/phalcon/cphalcon/blob/master/phalcon/acl/adapter/memory.zep#L682 handle when no access was found. Right now things doesn't work as expected i think. Or maybe we should change allow/deny methods to always at add beginning of array, not at the end.

I was changing one time other issue, maybe it created this, i don't know. Will create PR with fix i guess.

Provide minimal script to reproduce the issue

$acl = new Memory();
$acl->setDefaultAccess(\Phalcon\Acl::DENY);
$acl->addResource('Test', ['one', 'two']);
$acl->addRole('ROLE1');
$acl->allow('ROLE1', 'Test', 'one');
$acl->isAllowed('ROLE1', 'Test', 'one'); // will return false

Details

• Phalcon version: 3.1.x
• PHP Version: 7.0.13
• Operating System: Unbuntu 14.04
• Installation type: Compiling from source
• Zephir version: 0.9.5a-dev-bad1ef6b4d
• Server: cli

[Jurigag]

What you mean? Could you provide some example?

[Jurigag]

But i don't really see a point of doing this. Any example of code what you mean? Or you mean add way to get just only this function?

[Jurigag]

But i still don't know what you exactly mean.