New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to interfaces #12676

Closed
Jurigag opened this Issue Mar 3, 2017 · 2 comments

Comments

Projects
3 participants
@Jurigag
Copy link
Member

Jurigag commented Mar 3, 2017

This is list for Phalcon 4.0.0 with missing methods which should be in interfaces, feel free to add new comments here or discuss this list, i suggest one point - one interface with missing methods.

I ignored Phalcon\Http namespace cuz it's planned to switch to PSR7 anyway.

  • Phalcon\Annotations\AdapterInterface - read, write
  • Phalcon\Cache\BackendInterface - increment, decrement, flush
  • Phalcon\Cli\Router\RouteInterface - delimiter, getDelimiter
  • Phalcon\Cli\DispatcherInterface - setOptions, getOptions
  • Phalcon\Db\AdapterInterface - fetchColumn, insertAsDict, updateAsDict
  • Phalcon\Db\DialectInterface - registerCustomFunction, getCustomFunctions, getSqlExpression
  • Phalcon\Di\ServiceInterface - getParameter, isResolved
  • Phalcon\Events\ManagerInterface - hasListeners
  • Phalcon\Mvc\Model\Query\BuilderInterface - distinct, getDistinct, forUpdate, offset, getOffset
  • Phalcon\Mvc\Model\Transaction\ManagerInterface - setDbService, getDbService, setRollbackPendent, getRollbackPendent
  • Phalcon\Mvc\Model\CriteriaInterface - distinct, leftJoin, innerJoin, rightJoin, groupBy, having, cache, getColumns, getGroupBy, getHaving
  • Phalcon\Mvc\Model\ManagerInterface - isVisibleModelProperty, keepSnapshots, isKeepingSnapshots, useDynamicUpdate, isUsingDynamicUpdate, addHasManyToMany, existsHasManyToMany, getRelationRecords, getHasManyToMany, registerNamespaceAlias, getNamespaceAlias
  • Phalcon\Mvc\Model\MessageInterface - setModel, getModel, setCode, getCode
  • Phalcon\Mvc\Model\QueryInterface - getSingleResult, setBindParams, getBindParams, setBindTypes, setSharedLock, getBindTypes, getSql
  • Phalcon\Mvc\Model\RelationInterface - getParams
  • Phalcon\Mvc\Model\ResultsetInterface - setHydrateMode, getHydrateMode, getMessages, update, delete, filter
  • Phalcon\Mvc\ModelInterface::getModelsMetaData
  • Phalcon\Session\AdapterInterface - setId, status
  • Phalcon\Validation\MessageInteraface - getCode, setCode
  • Phalcon\CryptInterface - setPadding
@niden

This comment has been minimized.

Copy link
Member

niden commented Dec 21, 2018

  • Phalcon\Annotations\AdapterInterface - read, write <- Could not find that
  • Phalcon\Cache\BackendInterface - Cache will be refactored

niden added a commit to niden/cphalcon that referenced this issue Dec 21, 2018

@niden niden referenced this issue Dec 21, 2018

Merged

[#12676] - Changes to the interfaces #13675

2 of 3 tasks complete

niden added a commit to niden/cphalcon that referenced this issue Dec 21, 2018

niden added a commit to niden/cphalcon that referenced this issue Dec 22, 2018

[phalcon#12676] - Merge branch '4.0.x' into T12676-add-methods-to-int…
…erfaces

* 4.0.x: (40 commits)
  [4.0.x] - Another correction to the test
  Corrected test
  Fixed tests
  Removed obsolete file
  Fixed the method signature
  PHPCS fix
  Fixed tabs
  Corrected tests
  [phalcon#12833] - Updated the changelog
  [phalcon#12833] - Deleted obsolete tests
  [phalcon#12833] - PHPCS fixes
  [phalcon#12833] - Corrections to the manager and test (cleanup superglobal on destroy)
  [phalcon#12833] - Fixes and corrections to the tests
  [phalcon#12833] - Corrections to the tests and files adapter
  [phalcon#12833] - Fixed tests; Added exception in session for non valid handler
  [phalcon#12833] - Full tests for Session\Adapter; Adjustments to the environment; Test stubs
  [phalcon#12833] - Corrections and adding files adapter tests
  [phalcon#12833] - Correction to the redis session adapter; Work on the test traits
  [phalcon#12833] - Setup default session_save path to /tmp
  [phalcon#12833] - Cleanup for tests
  ...

niden added a commit to niden/cphalcon that referenced this issue Dec 23, 2018

[phalcon#12676] - Merge branch '4.0.x' into T12676-add-methods-to-int…
…erfaces

* 4.0.x:
  Merge for phalcon#12547
  Added some methods to Phalcon\Acl\Adapter\Memory
  [phalcon#12295] - Removed the final from the class definition
  [phalcon#12295] - Updated the changelog
  [phalcon#12295] - Added container tests
  [phalcon#12295] - Added Container object, PSR-11 compliant
  [phalcon#12295] - Added entry to the changelog
  [phalcon#12295] - Fixed interface
  [4.0.x] - Another correction to the test

niden added a commit to niden/cphalcon that referenced this issue Dec 24, 2018

[phalcon#12676] - Merge branch '4.0.x' into T12676-add-methods-to-int…
…erfaces

* 4.0.x:
  Fixes phalcon#12975, phalcon#13477: allowEmptyStrings & skipAttributes adhere col map

niden added a commit that referenced this issue Dec 24, 2018

Merge branch 'T12676-add-methods-to-interfaces' of https://github.com…
…/niden/cphalcon into niden-T12676-add-methods-to-interfaces

* 'T12676-add-methods-to-interfaces' of https://github.com/niden/cphalcon:
  [#12676] - Updated the changelog
  [#12676] - Changes to the interfaces

niden added a commit that referenced this issue Dec 24, 2018

Merge branch 'niden-T12676-add-methods-to-interfaces' into 4.0.x
* niden-T12676-add-methods-to-interfaces:
  [#12676] - Updated the changelog
  [#12676] - Changes to the interfaces
@niden

This comment has been minimized.

Copy link
Member

niden commented Dec 24, 2018

This has been addressed

@niden niden closed this Dec 24, 2018

4.0 Release automation moved this from In progress to Done Dec 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment