New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volt strings do not know about escape sequences #12888

Closed
fichtner opened this Issue Jun 9, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@fichtner
Copy link

fichtner commented Jun 9, 2017

Expected and Actual Behavior

In Volt the string 'Let\'s Encrypt' should be handled like "Let's Encrypt".

However, using 'Let\'s Encrypt' causes a parser failure. This is especially problematic with strings that have both single and double quotes as there is no way to have them in one contained string.

This is suboptimal for translation efforts, where we need contained strings with longer text to be embedded into the templates in the first place.

Parse error: syntax error, unexpected 'to' (T_STRING), expecting ',' or ')'

Details

  • Phalcon version: 3.1.2
  • PHP Version: 7.0
  • Operating System: FreeBSD
  • Installation type: package manager
  • Server: Lighttpd

@fichtner fichtner referenced this issue Jun 9, 2017

Closed

Template renewal #24

@sergeyklay sergeyklay self-assigned this Jun 19, 2017

@sergeyklay sergeyklay added this to the unplanned milestone Jun 19, 2017

@sergeyklay sergeyklay added the Volt label Oct 18, 2017

@stale

This comment has been minimized.

Copy link

stale bot commented Apr 16, 2018

Thank you for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please feel free to either reopen this issue or open a new one. We will be more than happy to look at it again! You can read more here: https://blog.phalconphp.com/post/github-closing-old-issues

@stale stale bot added the stale label Apr 16, 2018

@sergeyklay sergeyklay closed this Apr 16, 2018

@fichtner

This comment has been minimized.

Copy link
Author

fichtner commented Apr 16, 2018

@sergeyklay I'm not sure if this was fixed, if not this is an elementary feature for all string processing engines and should at least kept on the radar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment