Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request getPut #12892

Closed
Jurigag opened this Issue Jun 13, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@Jurigag
Copy link
Member

Jurigag commented Jun 13, 2017

Currently getPut is working only on form data, like on raw body request. When you send json it doesn't work and you need to use getJsonRawBody anyway. Im thinking about checking request header - if it's application/json, then use getJsonRawBody instead of getRawBody in getPut method.

To not introduce some big breaking change(will it break anything though?) it could be as php.ini option to enable this behavior.

Any thoughts?

@sergeyklay

This comment has been minimized.

Copy link
Member

sergeyklay commented Jun 13, 2017

Could you please provide a small script to reproduce

@Jurigag

This comment has been minimized.

Copy link
Member Author

Jurigag commented Jun 13, 2017

What you mean? It's NFR.

$this->request->getPut('id');

When sending json body with, id value will don't return anything. Just go into source code of getPut method, you will already see what i mean.

@sergeyklay sergeyklay added this to the unplanned milestone Jun 19, 2017

@stale

This comment has been minimized.

Copy link

stale bot commented Apr 16, 2018

Thank you for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please feel free to either reopen this issue or open a new one. We will be more than happy to look at it again! You can read more here: https://blog.phalconphp.com/post/github-closing-old-issues

@stale stale bot added the stale label Apr 16, 2018

@sergeyklay sergeyklay closed this Apr 16, 2018

@itbdw

This comment has been minimized.

Copy link

itbdw commented Jul 3, 2018

@Jurigag you have pointed this problem at 2017?

And now is 2018, still exists 😢

@sergeyklay sergeyklay reopened this Jul 3, 2018

@stale stale bot removed the stale label Jul 3, 2018

@sergeyklay sergeyklay modified the milestones: unplanned, 3.4.1 Jul 3, 2018

@sergeyklay

This comment has been minimized.

Copy link
Member

sergeyklay commented Jul 3, 2018

Fixed in the 3.4.x branch. Feel free to open a new issue if the problem appears again. Thank you for contributing.

@sergeyklay sergeyklay closed this Jul 3, 2018

@sergeyklay sergeyklay self-assigned this Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.