New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] \Phalcon\Mvc\Model\Query->addFrom() disregarding "with" argument #13023

Closed
kornerita opened this Issue Aug 17, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@kornerita

kornerita commented Aug 17, 2017

Hi,

We can see in \Phalcon\Mvc\Model\Query here, that the with parameter is disregarded in the addFrom method, I believe than this line of code is missing (taken from the constructor where is not disregarded).

Regards,
Federico.

@sergeyklay sergeyklay self-assigned this Oct 3, 2017

@sergeyklay sergeyklay added this to the 3.2.x milestone Oct 3, 2017

@sergeyklay

This comment has been minimized.

Show comment
Hide comment
@sergeyklay

sergeyklay Oct 3, 2017

Member

@kornerita Good catch! Thank you

Member

sergeyklay commented Oct 3, 2017

@kornerita Good catch! Thank you

@kornerita

This comment has been minimized.

Show comment
Hide comment
@kornerita

kornerita Oct 3, 2017

No problem, I found it just browsing code hehe.

kornerita commented Oct 3, 2017

No problem, I found it just browsing code hehe.

@sergeyklay

This comment has been minimized.

Show comment
Hide comment
@sergeyklay

sergeyklay Oct 3, 2017

Member

Long story short. This feature was introduced at Jun 1, 2015 (3e43192) was removed at Aug 6, 2015 (3ca2504). Actually this feature was never used in stable releases.

We will not add this feature into 3.x branch and most likely will refactor QueryBuilder in 4.x branch. Thus I just mark (#13109) this feature as deprecated to avoid misunderstandings for future developers.

To see team's opinion about Eager Loading refer to: #1117 .

Thank you for the report, and for helping us make Phalcon better.

Member

sergeyklay commented Oct 3, 2017

Long story short. This feature was introduced at Jun 1, 2015 (3e43192) was removed at Aug 6, 2015 (3ca2504). Actually this feature was never used in stable releases.

We will not add this feature into 3.x branch and most likely will refactor QueryBuilder in 4.x branch. Thus I just mark (#13109) this feature as deprecated to avoid misunderstandings for future developers.

To see team's opinion about Eager Loading refer to: #1117 .

Thank you for the report, and for helping us make Phalcon better.

@sergeyklay sergeyklay closed this Oct 3, 2017

@sergeyklay sergeyklay added Bug - Low and removed Bug - Medium labels Oct 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment