/cphalcon

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Phalcon\Http\RequestInterface #13061

Closed
kornerita opened this Issue Sep 6, 2017 · 5 comments

Comments

Assignees

@niden niden

Labels
Enhancement
Projects
  
Done in 4.0 Release
Milestone
  4.0.0
4 participants
@kornerita @sergeyklay @virgofx @niden
@kornerita
Copy link

kornerita commented Sep 6, 2017

Hi,

I would like to ask for an update in Phalcon\Http\RequestInterface to match the following Phalcon\Http\Request methods for compatibility:

This would be for Phalcon 4+ for backward compatibility on 3rd party existing implementations of RequestInterface.

Thanks,
Federico.

@sergeyklay sergeyklay added the Enhancement label Oct 2, 2017

@sergeyklay sergeyklay added this to the 4.0.0 milestone Oct 2, 2017

@sergeyklay

This comment has been minimized.

Sign in to view
Copy link
Member

sergeyklay commented Oct 2, 2017

Good catch. Thank you 👍
@kornerita

This comment has been minimized.

Sign in to view
Copy link
Author

kornerita commented Oct 3, 2017

No problem :)

@stale stale bot added the stale label Apr 16, 2018

@sergeyklay sergeyklay closed this Apr 16, 2018

@sergeyklay sergeyklay reopened this May 2, 2018

@stale stale bot removed the stale label May 2, 2018

@virgofx

This comment has been minimized.

Sign in to view
Copy link
Member

virgofx commented Dec 17, 2018 •
edited

Also missing getURI()

Found this existing issue for you Niden. I would just run through both side by side to see if any additional ones are missing.

CC: @niden
Reference: #13659

@phalcon phalcon deleted a comment from stale bot Dec 17, 2018

@niden niden added this to To do in 4.0 Release via automation Dec 17, 2018

@niden niden self-assigned this Dec 17, 2018

niden added a commit to niden/cphalcon that referenced this issue Dec 17, 2018

@niden
[phalcon#13061] - Aligned interfaces
Verified
This commit was signed with a verified signature.
@niden niden Nikolaos Dimopoulos
GPG key ID: 3A7A27B0ED8B3641 Learn about signing commits
bdf35e5

niden added a commit to niden/cphalcon that referenced this issue Dec 17, 2018

@niden
[phalcon#13061] - Added test for the interface
Verified
This commit was signed with a verified signature.
@niden niden Nikolaos Dimopoulos
GPG key ID: 3A7A27B0ED8B3641 Learn about signing commits
Loading status checks…
7f4b5d1

@niden niden moved this from To do to In progress in 4.0 Release Dec 17, 2018

@niden niden referenced this issue Dec 17, 2018

Merged

T13061 request interface sync #13666

3 of 3 tasks complete

niden added a commit to niden/cphalcon that referenced this issue Dec 17, 2018

@niden
[phalcon#13061] - Updated changelog
Verified
This commit was signed with a verified signature.
@niden niden Nikolaos Dimopoulos
GPG key ID: 3A7A27B0ED8B3641 Learn about signing commits
Loading status checks…
454c933

niden added a commit that referenced this issue Dec 17, 2018

@niden
[#13061] - Aligned interfaces
e93b501

niden added a commit that referenced this issue Dec 17, 2018

@niden
[#13061] - Added test for the interface
1d06547

niden added a commit that referenced this issue Dec 17, 2018

@niden
[#13061] - Updated changelog
Loading status checks…
1adbaff

@niden niden moved this from In progress to Done in 4.0 Release Dec 17, 2018

@sergeyklay

This comment has been minimized.

Sign in to view
Copy link
Member

sergeyklay commented Dec 17, 2018

@niden Whether this addressed?

niden added a commit to niden/cphalcon that referenced this issue Dec 18, 2018

@niden
[phalcon#12921] - Merge branch '4.0.x' into T12921-remove-session-fro… 
…m-di-factory

* 4.0.x:
  [phalcon#13061] - Updated changelog
  [phalcon#13061] - Added test for the interface
  [phalcon#13061] - Aligned interfaces
  [phalcon#13639] - Updated the changelog
  [phalcon#13639] - Corrected tests
  [phalcon#13639] - Corrected tests
  [phalcon#13639] - Renamed Acl\Role to Acl\Operation
  [phalcon#13639] - Renamed Acl\Resource to Acl\Subject
Verified
This commit was signed with a verified signature.
@niden niden Nikolaos Dimopoulos
GPG key ID: 3A7A27B0ED8B3641 Learn about signing commits
684f316
@niden

This comment has been minimized.

Sign in to view
Copy link
Member

niden commented Dec 18, 2018

@sergeyklay The PR synched the interfaces between Request and RequestInterface

#13666

@niden niden closed this Dec 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment