New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFR] Implement Model\MetaData\Apcu #13078

Closed
hakimio opened this Issue Sep 20, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@hakimio

hakimio commented Sep 20, 2017

Expected and Actual Behavior

I would expect APC extension dependency to be fully removed in Phalcon 3.2, but it seems "Phalcon\Mvc\Model\MetaData\Apc" is still using it.

Details

  • Phalcon version: 3.2.2
  • PHP Version: 7.1
  • Operating System: Windows 10
  • Installation type: precompiled Windows dll
  • Zephir version (if any): 0.9.9-868cb1f92b
  • Server: Apache

@sergeyklay sergeyklay added this to the 4.0.0 milestone Sep 20, 2017

@Jurigag

This comment has been minimized.

Show comment
Hide comment
@Jurigag

Jurigag Sep 20, 2017

Member

It will be in phalcon 4. We follow semver so we couldn't remove it in phalcon 3.2. Don't really see a problem, just install apcu_bc.

Member

Jurigag commented Sep 20, 2017

It will be in phalcon 4. We follow semver so we couldn't remove it in phalcon 3.2. Don't really see a problem, just install apcu_bc.

@hakimio

This comment has been minimized.

Show comment
Hide comment
@hakimio

hakimio Sep 20, 2017

I am using apcu_bc, but ideally I would like to get rid of it.
You could leave "Phalcon\Mvc\Model\MetaData\Apc" as is for compatibility and simply introduce a new one called "Phalcon\Mvc\Model\MetaData\Apcu" for those who want to use it.
Later in version 4, you can remove it entirely.

hakimio commented Sep 20, 2017

I am using apcu_bc, but ideally I would like to get rid of it.
You could leave "Phalcon\Mvc\Model\MetaData\Apc" as is for compatibility and simply introduce a new one called "Phalcon\Mvc\Model\MetaData\Apcu" for those who want to use it.
Later in version 4, you can remove it entirely.

@Jurigag

This comment has been minimized.

Show comment
Hide comment
@Jurigag

Jurigag Sep 20, 2017

Member

Yea i was proposing this already. But this should be in 3.3, so w really need version 3.3 @sergeyklay

Member

Jurigag commented Sep 20, 2017

Yea i was proposing this already. But this should be in 3.3, so w really need version 3.3 @sergeyklay

@sergeyklay sergeyklay modified the milestones: 4.0.0, 3.3.x Sep 25, 2017

@sergeyklay sergeyklay changed the title from Use APCu instead of APC in "Model\MetaData\Apc" to [NFR] Implement Model\MetaData\Apcu Sep 25, 2017

@sergeyklay sergeyklay self-assigned this Oct 2, 2017

Jurigag added a commit to Jurigag/cphalcon that referenced this issue Nov 24, 2017

@Jurigag Jurigag referenced this issue Nov 24, 2017

Merged

Implements #13078 #13182

3 of 3 tasks complete

sergeyklay added a commit that referenced this issue Nov 25, 2017

@sergeyklay

This comment has been minimized.

Show comment
Hide comment
@sergeyklay

sergeyklay Nov 25, 2017

Member

Implemented in the 3.3.x branch. Thank you for contributing.

Member

sergeyklay commented Nov 25, 2017

Implemented in the 3.3.x branch. Thank you for contributing.

@sergeyklay sergeyklay closed this Nov 25, 2017

chilimatic added a commit to chilimatic/cphalcon that referenced this issue Jan 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment