New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different MessageInterfaces in Models and Validation #13114

Closed
grigoriy-ivanov opened this Issue Oct 8, 2017 · 2 comments

Comments

Projects
3 participants
@grigoriy-ivanov
Copy link

grigoriy-ivanov commented Oct 8, 2017

Phalcon has two different MessageInterfaces:
Phalcon\Validation\MessageInterface, Phalcon\Mvc\Model\MessageInterface with same code.

I think will be perfect to create Phalcon Messages component Phalcon\Messages:

Phalcon\Messages\MessageInterface for message
Phalcon\Messages\GroupInterface for a collection of Messages with filter/map/etc. methods

@stale

This comment has been minimized.

Copy link

stale bot commented Apr 16, 2018

Thank you for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please feel free to either reopen this issue or open a new one. We will be more than happy to look at it again! You can read more here: https://blog.phalconphp.com/post/github-closing-old-issues

@stale stale bot added the stale label Apr 16, 2018

@sergeyklay sergeyklay closed this Apr 16, 2018

@sergeyklay sergeyklay reopened this May 2, 2018

@stale stale bot removed the stale label May 2, 2018

niden added a commit to niden/cphalcon that referenced this issue Oct 17, 2018

niden added a commit to niden/cphalcon that referenced this issue Oct 17, 2018

niden added a commit to niden/cphalcon that referenced this issue Oct 17, 2018

niden added a commit to niden/cphalcon that referenced this issue Oct 17, 2018

niden added a commit to niden/cphalcon that referenced this issue Oct 17, 2018

niden added a commit to niden/cphalcon that referenced this issue Oct 17, 2018

niden added a commit to niden/cphalcon that referenced this issue Oct 17, 2018

niden added a commit to niden/cphalcon that referenced this issue Oct 17, 2018

niden added a commit to niden/cphalcon that referenced this issue Oct 17, 2018

niden added a commit to niden/cphalcon that referenced this issue Oct 17, 2018

niden added a commit to niden/cphalcon that referenced this issue Oct 17, 2018

niden added a commit to niden/cphalcon that referenced this issue Oct 17, 2018

niden added a commit to niden/cphalcon that referenced this issue Oct 17, 2018

niden added a commit to niden/cphalcon that referenced this issue Oct 17, 2018

niden added a commit to niden/cphalcon that referenced this issue Oct 17, 2018

niden added a commit to niden/cphalcon that referenced this issue Oct 17, 2018

@niden niden referenced this issue Oct 17, 2018

Merged

T13114 message interfaces #13534

3 of 3 tasks complete

@niden niden self-assigned this Oct 17, 2018

niden added a commit to niden/cphalcon that referenced this issue Oct 18, 2018

niden added a commit to niden/cphalcon that referenced this issue Oct 18, 2018

niden added a commit to niden/cphalcon that referenced this issue Oct 18, 2018

niden added a commit to niden/cphalcon that referenced this issue Oct 18, 2018

niden added a commit to niden/cphalcon that referenced this issue Oct 18, 2018

niden added a commit to niden/cphalcon that referenced this issue Oct 18, 2018

niden added a commit to niden/cphalcon that referenced this issue Oct 18, 2018

niden added a commit to niden/cphalcon that referenced this issue Oct 18, 2018

niden added a commit to niden/cphalcon that referenced this issue Oct 18, 2018

[phalcon#13114] - Merge branch '4.0.x' into T13114-message-interfaces
* 4.0.x:
  [phalcon#13468] - Added `getHandlerSuffix()`, `setHandlerSuffix()` in Dispatcher, `getTaskSuffix()`, `setTaskSuffix()` in the CLI Dispatcher
  [phalcon#13529] - Moved the sharedLock in the dialects. PostgreSql and Sqlite return the original query
  Added entry in the changelog
  Corrected Message
  Correcte test
  Corrected call to getTemplate; removed unused variables
  Test corrections
  Correction in variables
  Removed unused variable; Corrected variable name
  Minor refactor of the escaping and html message
  Added custom template in prepareHtml
  Alpha sort of methods

niden added a commit to niden/cphalcon that referenced this issue Oct 18, 2018

[phalcon#13114] - Merge branch 'T13114-message-interfaces' of git://g…
…ithub.com/niden/cphalcon into T13114-message-interfaces

* 'T13114-message-interfaces' of git://github.com/niden/cphalcon:

sergeyklay added a commit that referenced this issue Oct 19, 2018

T13114 message interfaces (#13534)
* [#13114] - Added messages component and relevant interface

* [#13114] - Added message exception

* [#13114] - Added messages collection (renamed from group)

* [#13114] - Removed message objects from validation

* [#13114] - Removed the group class in favor of the messages one

* [#13114] - Replace of Group with Messages object

* [#13114] - Removed model messageinterface; Refactored model message; Corrected use reference

* [#13114] - Corrected class extend

* [#13114] - Test corrections

* [#13114] - Corrected methods/objects

* [#13114] - More test corrections

* [#13114] - Fixing tests

* [#13114] - Corrected order in adding messages with a model

* [#13114] - Correcting more tests

* [#13114] - Removed the Mvc\Model\Message class - using the Messages\Message

* [#13114] - Updated the changelog

* [#13114] - Added JsonSerializable interface in Message and Messages

* [#13114] - Corrected noobie typo

* [#13114] - More noobie typos

* [#13114] - Changed the variable type

* [#13114] - Forgot the implements :/

* [#13114] - Corrected test

* [#13114] - Changed the var type

* [#13114] - Array initialization that was missing
@niden

This comment has been minimized.

Copy link
Member

niden commented Oct 19, 2018

This has been implemented in 4.x

@niden niden closed this Oct 19, 2018

@niden niden referenced this issue Oct 19, 2018

Open

Update 4.x Documents #1935

0 of 10 tasks complete

@niden niden added this to Done in 4.0 Release Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment