New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convert method to the Phalcon\Mvc\Router\RouteInterface #13380

Closed
sergeyklay opened this Issue May 16, 2018 · 1 comment

Comments

Projects
1 participant
@sergeyklay
Copy link
Member

sergeyklay commented May 16, 2018

The documentation for Phalcon\Mvc\Router\Group::add states, that add() on a group would return an instance of RouteInterface but it really returns an instance of Route.

After calling add we shouldn't call convert because convert is a Route member but not RouteInterface.

@sergeyklay sergeyklay added this to the 4.0.0 milestone May 16, 2018

@sergeyklay sergeyklay changed the title Add convert method to the Phalcon\Mvc\RouteInterface Add convert method to the Phalcon\Mvc\Router\RouteInterface May 31, 2018

@sergeyklay sergeyklay referenced this issue May 31, 2018

Merged

Added RouteInterface::convert #13392

2 of 3 tasks complete
@sergeyklay

This comment has been minimized.

Copy link
Member Author

sergeyklay commented May 31, 2018

Implemented in the 4.0.x branch.

@sergeyklay sergeyklay closed this May 31, 2018

@niden niden referenced this issue Oct 19, 2018

Open

Update 4.x Documents #1935

0 of 10 tasks complete

@niden niden added this to Done in 4.0 Release Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment