New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent naming convention in Dispatcher classes, no way to retrieve a settable value (handler suffix) #13468

Closed
terax6669 opened this Issue Aug 20, 2018 · 1 comment

Comments

Projects
2 participants
@terax6669
Copy link

terax6669 commented Aug 20, 2018

Expected and Actual Behavior

Expected:

Available methods:

\Phalcon\Dispatcher::getHandlerSuffix()
\Phalcon\Dispatcher::setHandlerSuffix()

or

\Phalcon\Cli\Dispatcher::getTaskSuffix()

Actual

There is a \Phalcon\Cli\Dispatcher::setTaskSuffix() method that sets _handlerSuffix - this is inconsistent.
After using setTaskSuffix there is no way to read the new value from the dispatcher.

Details

  • Phalcon version: 3.4.1

@niden niden self-assigned this Oct 15, 2018

niden added a commit to niden/cphalcon that referenced this issue Oct 18, 2018

[phalcon#13468] - Added `getHandlerSuffix()`, `setHandlerSuffix()` in…
… Dispatcher, `getTaskSuffix()`, `setTaskSuffix()` in the CLI Dispatcher

niden added a commit that referenced this issue Oct 18, 2018

Merge pull request #13536 from niden/T13468-inconsistent-naming-conve…
…ntion-in-dispatcher-2

[#13468] - Added `getHandlerSuffix()`, `setHandlerSuffix()` in Dispatcher

niden added a commit to niden/cphalcon that referenced this issue Oct 18, 2018

[phalcon#13114] - Merge branch '4.0.x' into T13114-message-interfaces
* 4.0.x:
  [phalcon#13468] - Added `getHandlerSuffix()`, `setHandlerSuffix()` in Dispatcher, `getTaskSuffix()`, `setTaskSuffix()` in the CLI Dispatcher
  [phalcon#13529] - Moved the sharedLock in the dialects. PostgreSql and Sqlite return the original query
  Added entry in the changelog
  Corrected Message
  Correcte test
  Corrected call to getTemplate; removed unused variables
  Test corrections
  Correction in variables
  Removed unused variable; Corrected variable name
  Minor refactor of the escaping and html message
  Added custom template in prepareHtml
  Alpha sort of methods

@niden niden added this to the 4.0.0 milestone Oct 19, 2018

@niden niden added the Breaks BC label Oct 19, 2018

@niden

This comment has been minimized.

Copy link
Member

niden commented Oct 19, 2018

This has been implemented in 4.x

@niden niden closed this Oct 19, 2018

@niden niden referenced this issue Oct 19, 2018

Open

Update 4.x Documents #1935

0 of 10 tasks complete

@niden niden added this to Done in 4.0 Release Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment