New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add method close() to Phalcon\Session\AdapterInterface #13535

Closed
michalzielanski opened this Issue Oct 18, 2018 · 2 comments

Comments

Projects
3 participants
@michalzielanski
Copy link

michalzielanski commented Oct 18, 2018

Please add the close method in the session adapters. For Phalcon\Session\Adapter\Files, the method should call session_write_close(). This will allow to close the session and unlock the session file.

http://konrness.com/php5/how-to-prevent-blocking-php-requests/
https://stackoverflow.com/questions/13651195/long-running-background-php-script-blocks-other-php-pages-until-it-is-finished

@Jurigag

This comment has been minimized.

Copy link
Member

Jurigag commented Oct 18, 2018

Well it's actually good idea, i actually even used it for event source that you need to close it to make everything working properly.

@Jurigag Jurigag added the Enhancement label Oct 18, 2018

@Jurigag Jurigag added this to the 4.0.0 milestone Oct 18, 2018

@Jurigag Jurigag referenced this issue Oct 19, 2018

Merged

Reorganized/cleaned up Session classes #13538

2 of 3 tasks complete

@niden niden added this to In progress in 4.0 Release Nov 28, 2018

@niden niden moved this from In progress to To do in 4.0 Release Nov 28, 2018

@niden niden moved this from To do to In progress in 4.0 Release Dec 21, 2018

@niden niden referenced this issue Dec 21, 2018

Merged

T12833 session interface #13673

3 of 3 tasks complete
@niden

This comment has been minimized.

Copy link
Member

niden commented Dec 21, 2018

@michalzielanski Thank you for reporting this. Addressed in #13673

@niden niden closed this Dec 21, 2018

4.0 Release automation moved this from In progress to Done Dec 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment