New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFR] Add Phalcon\Db\Dialect\Sqlite::forUpdate #13539

Closed
TimurFlush opened this Issue Oct 19, 2018 · 3 comments

Comments

Projects
3 participants
@TimurFlush
Copy link

TimurFlush commented Oct 19, 2018

Hello
Add method forUpdate() to dialects please)

P.S Addition to the problem #13529

@sergeyklay sergeyklay added this to the 4.0.0 milestone Oct 19, 2018

@niden

This comment has been minimized.

Copy link
Member

niden commented Oct 19, 2018

public function forUpdate(string! sqlQuery) -> string
	{
		return sqlQuery . " FOR UPDATE";
	}

Like this?

@TimurFlush

This comment has been minimized.

Copy link
Author

TimurFlush commented Oct 19, 2018

@niden Judging by the name of the method, the answer is clear.

niden added a commit to niden/cphalcon that referenced this issue Oct 19, 2018

[phalcon#13539] - Added forUpdate in sqlite dialect to remove the FOR…
… UPDATE from the query present in other two dialects

@sergeyklay sergeyklay changed the title forUpdate [NFR] Add Phalcon\Db\Dialect\Sqlite::forUpdate Oct 19, 2018

@niden niden referenced this issue Oct 19, 2018

Merged

[#13539] - Added forUpdate in sqlite dialect #13542

2 of 3 tasks complete

niden added a commit to niden/cphalcon that referenced this issue Oct 19, 2018

niden added a commit that referenced this issue Oct 19, 2018

Merge pull request #13542 from niden/T13539-dialect-for-update
[#13539] - Added forUpdate in sqlite dialect
@niden

This comment has been minimized.

Copy link
Member

niden commented Oct 19, 2018

This has been addressed in 4.x

@niden niden closed this Oct 19, 2018

niden added a commit to niden/cphalcon that referenced this issue Oct 31, 2018

Merge branch '4.0.x' into T12833-standardize-session-interface
* 4.0.x:
  [phalcon#13543] - One more change to the interface
  [phalcon#13543] - Reverted test and added return values to methods/interface
  [phalcon#13543] - Corrected use statements again
  [phalcon#13543] - Removed use statement
  [phalcon#13543] - Corrected return type
  [phalcon#13543] - Interface corretions
  [phalcon#13543] - Corrections to the interface/class
  [phalcon#13543] - More reorganization
  [phalcon#13543] - Reorganization
  [phalcon#13543] - Reorganized methods
  [phalcon#13543] - Copyright notices
  [phalcon#13543] - More alpha sorting
  [phalcon#13543] - Changed copyright notices; Sorted methods and properties
  [phalcon#13543] - Reorganized class methods
  Updated the changelog
  [phalcon#13539] - Updated the changelog
  [phalcon#13539] - Added forUpdate in sqlite dialect to remove the FOR UPDATE from the query present in other two dialects
  updating unit tests
  adding TYPE_ENUM to Phalcon\Db\Column
  Updatet the CHANGELOG.md [ci skip]

@niden niden added this to Done in 4.0 Release Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment