Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Phalcon\Mvc\Url #13742

Closed
ekmst opened this Issue Jan 8, 2019 · 5 comments

Comments

Projects
5 participants
@ekmst
Copy link
Contributor

ekmst commented Jan 8, 2019

I propose to rename Phalcon\Mvc\Url to Phalcon\Url. Since the Url is used not only in web applications but also in console (and micro) applications too. I think it will be semantic more correct.

  • Phalcon\Mvc\Url to Phalcon\Url
  • Phalcon\Mvc\UrlInterface to Phalcon\UrlInterface
  • Phalcon\Mvc\Url\Exception to Phalcon\Url\Exception
@dschissler

This comment has been minimized.

Copy link
Contributor

dschissler commented Jan 8, 2019

There is entirely too much stuff in the Phalcon\Mvc namespace.

@ekmst

This comment has been minimized.

Copy link
Contributor Author

ekmst commented Jan 8, 2019

There is entirely too much stuff in the Phalcon\Mvc namespace.

I agree.

I also suggest renaming Phalcon\Mvc\User\*, as they do not directly relate to the MVC pattern.

For example:

  • Phalcon\Mvc\User\Component to Phalcon\User\Component
  • Phalcon\Mvc\User\Module to Phalcon\User\Module
  • Phalcon\Mvc\User\Plugin to Phalcon\User\Plugin
@ViltusVilks

This comment has been minimized.

Copy link

ViltusVilks commented Jan 8, 2019

If they are empty then can be abandoned also, because Injectable can be used directly in PHP.
Less code is better.

And why User\Module exists? we have...
class Module implements ModuleDefinitionInterface { ... }

@niden

This comment has been minimized.

Copy link
Member

niden commented Jan 9, 2019

@ekmst The Phalcon\Mvc\User\* classes will be removed for sure. We were thinking about leaving only one of them, something in the lines of Phalcon\Plugin maybe?

Honestly those classes do nothing. They just offer a more intuitive way to make a class DI aware which one can do easily by extending InjectionAware.

As for the Url. Yes I agree. It would be best if we move it out of the Mvc namespace and I would love to see if I can introduce also the Uri implementation for PSR7 and make those two work together.

@niden niden added the Enhancement label Jan 9, 2019

@niden niden added this to To do in 4.0 Release via automation Jan 9, 2019

@niden niden self-assigned this Jan 9, 2019

@ekmst ekmst referenced this issue Feb 15, 2019

Merged

renamed phalcon\mvc\url to phalcon\url #13831

3 of 3 tasks complete
@niden

This comment has been minimized.

Copy link
Member

niden commented Feb 16, 2019

This has been resolved

@niden niden closed this Feb 16, 2019

4.0 Release automation moved this from To do to Done Feb 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.