Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0.0] Rename Acl\Resource to Acl\Component #13808

Closed
tempcke opened this Issue Feb 7, 2019 · 1 comment

Comments

Projects
3 participants
@tempcke
Copy link

tempcke commented Feb 7, 2019

As was determined here: #13791
Phalcon\Acl\Role should revert back to what it is in 3.4 and Phalcon\Acl\Resource should be renamed Phalcon\Acl\Component

This also relates to #13639

Phalcon\Acl\Resource -> Phalcon\Acl\Component
Phalcon\Acl\ResourceInterface -> Phalcon\Acl\ComponentInterface
Phalcon\Acl\ResourceAware -> Phalcon\Acl\ComponentAware

These should remain unchanged from 3.4:
Phalcon\Acl\Role
Phalcon\Acl\RoleInterface
Phalcon\Acl\RoleAware


Update change log as well as blog post

@sergeyklay sergeyklay added this to the 4.0.0 milestone Feb 7, 2019

@sergeyklay sergeyklay added this to To do in 4.0 Release via automation Feb 7, 2019

@sergeyklay sergeyklay changed the title In Phalcon 4.0.0 Rename Acl\Resource to Acl\Component [4.0.0] Rename Acl\Resource to Acl\Component Feb 7, 2019

@niden niden self-assigned this Feb 8, 2019

niden added a commit to niden/cphalcon that referenced this issue Feb 8, 2019

niden added a commit to niden/cphalcon that referenced this issue Feb 8, 2019

@niden niden referenced this issue Feb 8, 2019

Merged

T13808 acl rename #13809

3 of 3 tasks complete

niden added a commit to niden/cphalcon that referenced this issue Feb 8, 2019

@niden niden moved this from To do to In progress in 4.0 Release Feb 8, 2019

niden added a commit that referenced this issue Feb 8, 2019

niden added a commit that referenced this issue Feb 8, 2019

niden added a commit that referenced this issue Feb 8, 2019

@niden

This comment has been minimized.

Copy link
Member

niden commented Feb 8, 2019

This has been addressed

@niden niden closed this Feb 8, 2019

4.0 Release automation moved this from In progress to Done Feb 8, 2019

niden added a commit to niden/cphalcon that referenced this issue Feb 8, 2019

[4.0.x] - Merge remote-tracking branch 'upstream/4.0.x' into 4.0.x
* upstream/4.0.x:
  Updated the changelog
  [phalcon#13808] - Updating ext folder
  [phalcon#13808] - Adjusting tests
  [phalcon#13808] - Renaming ACL elements

niden added a commit to niden/cphalcon that referenced this issue Feb 8, 2019

[phalcon#11789] - Merge branch '4.0.x' into T11789-PSR-7
* 4.0.x:
  Updated the changelog
  [phalcon#13808] - Updating ext folder
  [phalcon#13808] - Adjusting tests
  [phalcon#13808] - Renaming ACL elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.