Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace minifiers (css/js) #13819

Closed
niden opened this Issue Feb 11, 2019 · 6 comments

Comments

Projects
4 participants
@niden
Copy link
Member

niden commented Feb 11, 2019

The current minifiers for JS/CSS rely on a library by Douglas Crockford and its license is "BSD with restriction".

We need to remove this library and replace it with one that does not have restrictions or roll out a in-house implementation.

The library needs to be removed from v4 but the Phalcon classes will remain as they are, returning back (for now) the original file i.e. pretty much doing nothing. This is in order to keep SemVer happy when we do roll out the new minifying library (in future versions of v4)

Reference: #10118

@niden niden added this to To do in 4.0 Release via automation Feb 11, 2019

niden added a commit to niden/cphalcon that referenced this issue Feb 11, 2019

niden added a commit to niden/cphalcon that referenced this issue Feb 11, 2019

niden added a commit to niden/cphalcon that referenced this issue Feb 11, 2019

niden added a commit to niden/cphalcon that referenced this issue Feb 11, 2019

@ruudboon

This comment has been minimized.

Copy link
Member

ruudboon commented Feb 11, 2019

With all the current tools (webpack, grunt, less, sass. typescript etc) that are available noways I'm wondering if this is still a wanted feature in the framework or that it should be removed from the framework.

@niden niden referenced this issue Feb 11, 2019

Merged

T13819 remove minifiers #13820

3 of 3 tasks complete

niden added a commit to niden/cphalcon that referenced this issue Feb 11, 2019

@niden niden moved this from To do to In progress in 4.0 Release Feb 11, 2019

@niden niden removed the Breaks BC label Feb 11, 2019

@dschissler

This comment has been minimized.

Copy link
Contributor

dschissler commented Feb 12, 2019

I make extensive use of an optional Webpack in my Perch Framework. I would never consider using Phalcon for minifying.

niden added a commit that referenced this issue Feb 12, 2019

niden added a commit that referenced this issue Feb 12, 2019

niden added a commit that referenced this issue Feb 12, 2019

niden added a commit that referenced this issue Feb 12, 2019

@niden

This comment has been minimized.

Copy link
Member Author

niden commented Feb 12, 2019

Resolved

@niden niden closed this Feb 12, 2019

4.0 Release automation moved this from In progress to Done Feb 12, 2019

@dschissler

This comment has been minimized.

Copy link
Contributor

dschissler commented Feb 12, 2019

Less is more. If there is a solution for this then it is likely using a composer package. It would be nice in the future if Phalcon could have an official ecosystem of supporting PHP-land packages which are designed to act as glue code between other famous libraries.

@david-duncan

This comment has been minimized.

Copy link

david-duncan commented Feb 12, 2019

I couldn't agree more with the comments in this thread. Focus efforts on 7.4 and 8.x

@dschissler

This comment has been minimized.

Copy link
Contributor

dschissler commented Feb 12, 2019

@niden Is there a way to augment the filter factory from PHP land? If not then please design the API so that more filters could be added (if its not already).

@sergeyklay @niden
I'm thinking that you guys could make something like a phalcon_extras git repository. Then each directory could be for a composer package. Then make an effort to gobble up community created packages and to put it under the official Phalcon banner in phalcon_extras. Then give each (quality) package owner commit access to the repository to maintain their package. Then you can just control the release of the actual composer packages to make sure that crap doesn't get put out. Perhaps assign a new person to this role since you guys sometimes drop out for weeks at a time. This will all give the community a foot hold into the Phalcon project for contributing code. As it is now is too damn much of a chasm to get started. In regards to this particular minifier - I wouldn't use it but other people might and especially noobs or for toy projects.

niden added a commit to niden/cphalcon that referenced this issue Feb 13, 2019

[4.0.x] - Merge remote-tracking branch 'upstream/4.0.x' into 4.0.x
* upstream/4.0.x:
  [phalcon#2182] - Updated the changelog and PR template
  [phalcon#2182] - Added before/after compile events for Volt
  [phalcon#2182] - Removed some obsolete tests; Added tests for engine/render events
  Updated changelog
  fix tests
  change tests
  fix stan
  Add `Dispatcher::toCamelCase()` method
  [phalcon#13819] - Updated the changelog
  [phalcon#13819] - Removing css/js optimizers from the config
  [phalcon#13819] - Updating ext/
  [phalcon#13819] - Removed minifiers
  [phalcon#13819] - Marked tests as skipped

niden added a commit to niden/cphalcon that referenced this issue Feb 16, 2019

[phalcon#11789] - Merge branch '4.0.x' into T11789-PSR-7
* 4.0.x:
  Allow Config::merge to accept a basic array. (phalcon#13830)
  [phalcon#2182] - Updated the changelog and PR template
  [phalcon#2182] - Added before/after compile events for Volt
  [phalcon#2182] - Removed some obsolete tests; Added tests for engine/render events
  Updated changelog
  fix tests
  change tests
  fix stan
  Add `Dispatcher::toCamelCase()` method
  [phalcon#13819] - Updated the changelog
  [phalcon#13819] - Removing css/js optimizers from the config
  [phalcon#13819] - Updating ext/
  [phalcon#13819] - Removed minifiers
  [phalcon#13819] - Marked tests as skipped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.