Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Registry with Collection #13893

Closed
niden opened this issue Mar 12, 2019 · 1 comment

Comments

Projects
1 participant
@niden
Copy link
Member

commented Mar 12, 2019

Change Phalcon\Registry to use Phalcon\Collection to remove code duplication.

Change Phalcon\Session\Bag to also use the collection object

@niden niden added the Enhancement label Mar 12, 2019

@niden niden added this to To do in 4.0 Release via automation Mar 12, 2019

@niden niden moved this from To do to In progress in 4.0 Release Mar 12, 2019

@niden niden added the Breaks BC label Mar 12, 2019

@niden niden referenced this issue Mar 13, 2019

Merged

T13893 registry collection #13895

4 of 4 tasks complete

niden added a commit that referenced this issue Mar 13, 2019

T13893 registry collection (#13895)
* [4.0.x] - Added unicode flag for email filter

* [4.0.x] - Updating the ext folder

* [4.0.x] - Added Arr helper class

* Revert "[4.0.x] - Added Arr helper class"

This reverts commit f8153d3.

* Revert "[4.0.x] - Updating the ext folder"

This reverts commit 655eafe.

* [#13893] - Work on the registry extending Collection; Tests!

* [#13893] - Corrected the signature of __get

* [#13893] - Correction to the interface

* [#13893] - Case insensitivity on has and get

* [#13893] - Added more tests for case insensitivity

* [#13893] - Changed the Session\Bag component to use Collection

* [#13893] - Rework the Session\Bag tests

* [#13893] - Updated changelog

* [#13893] - Corrections after the review

* [#13893] - Removed ext/ files
@niden

This comment has been minimized.

Copy link
Member Author

commented Mar 13, 2019

Implemented

@niden niden closed this Mar 13, 2019

4.0 Release automation moved this from In progress to Done Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.