Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code quality/consistency in Phalcon\Mvc\View #14095

Closed
scrnjakovic opened this issue May 19, 2019 · 2 comments

Comments

@scrnjakovic
Copy link
Contributor

commented May 19, 2019

Any particular reason for using ob_end_clean(); instead of $view->finish() ? :)

cphalcon/phalcon/mvc/view.zep

Lines 1146 to 1159 in 6518334

/**
* Start the output buffering
*/
view->start();
/**
* Perform the render passing only the controller and action
*/
view->render(controllerName, actionName);
/**
* Stop the output buffering
*/
ob_end_clean();

@niden

This comment has been minimized.

Copy link
Member

commented May 19, 2019

None really. They both do the same thing. We should change that though to view->finish() to keep the consistency.

Nice catch.

@niden niden added this to To do in 4.0 Release via automation May 19, 2019

@niden niden added the Enhancement label May 19, 2019

@niden niden referenced this issue May 20, 2019

Merged

T14095 view inconsistency #14098

3 of 5 tasks complete

@niden niden moved this from To do to In progress in 4.0 Release May 20, 2019

@niden

This comment has been minimized.

Copy link
Member

commented May 20, 2019

Resolved in #14098

@niden niden closed this May 20, 2019

4.0 Release automation moved this from In progress to Done May 20, 2019

@niden niden added the 4.0 label Jun 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.