Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image::pixelate get error with imagecolorat() #14139

Closed
emiliodeg opened this issue May 27, 2019 · 1 comment

Comments

@emiliodeg
Copy link
Member

commented May 27, 2019

The php function imagecolorat get a color from (x,y) pixel, but works with index - 1

source

while x < this->width {
            let y = 0;

            while y < this->height {
                let x1 = x + amount/2; // here x1 can be equal or great than the image width
                let y1 = y + amount/2; // here y1 can be equal or great than the image height

when x1 or y1 are equal or great throw an error

Details

  • Phalcon version: 4.0.0 beta 1
  • PHP Version: 7.2.14
  • Operating System: nanobox 7.2
  • Installation type: Compiling from source
  • Zephir version (if any): 0.11.8
  • Server: Apache
  • Other related info (Database, table schema):

@emiliodeg emiliodeg referenced this issue May 27, 2019

Merged

T14139 image pixelate #14140

4 of 5 tasks complete
@niden

This comment has been minimized.

Copy link
Member

commented May 27, 2019

Addressed in #14140

@niden niden closed this May 27, 2019

@niden niden added the Bug - Low label May 27, 2019

@niden niden added this to To do in 4.0 Release via automation May 27, 2019

@niden niden moved this from To do to Done in 4.0 Release May 27, 2019

@niden niden added the 4.0 label Jun 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.