Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid logic in Validator/File/FileAbstract #14198

Closed
ekmst opened this issue Jun 21, 2019 · 1 comment

Comments

@ekmst
Copy link
Contributor

commented Jun 21, 2019

Missed getting value from validation in methods:

Validator/File/FileAbstract::checkUploadIsEmpty()

Validator/File/FileAbstract::checkUploadIsValid()

I think should be add:

let value = validation->getValue(field);

@emiliodeg

CameronHall added a commit to CameronHall/cphalcon that referenced this issue Jun 23, 2019

sergeyklay added a commit that referenced this issue Jun 23, 2019

@sergeyklay sergeyklay closed this Jun 23, 2019

@sergeyklay

This comment has been minimized.

Copy link
Member

commented Jun 23, 2019

Fixed in the 4.o.x branch. Thank you for contributing.

@niden niden added this to To do in 4.0 Release via automation Jun 23, 2019

@niden niden added the 4.0 label Jun 23, 2019

@niden niden moved this from To do to Done in 4.0 Release Jun 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.