Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Phalcon\Forms\Form::clear() variable never initialized #14217

Closed
scrnjakovic opened this issue Jun 27, 2019 · 1 comment

Comments

Projects
3 participants
@scrnjakovic
Copy link
Contributor

commented Jun 27, 2019

Condition on line 694 will never evaluate to true as variable field is null (v3.4.x)

public function clear(var fields = null) -> <Form>
{
var elements, element, data, field;
let data = this->_data;
if is_null(fields) {
let data = [];
} else {
if typeof fields == "array" {
for field in fields {
if isset data[field] {
unset data[field];
}
}
} else {
if isset data[field] {
unset data[field];
}
}
}

@SidRoberts

This comment has been minimized.

Copy link
Member

commented Jun 28, 2019

Fixed in #14218 and #14219.

@SidRoberts SidRoberts closed this Jun 28, 2019

@niden niden added this to To do in 4.0 Release via automation Jul 12, 2019

@niden niden moved this from To do to Done in 4.0 Release Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.