Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedisEngine setTimeout has deprecated #14281

Closed
alex-aff opened this issue Aug 4, 2019 · 4 comments

Comments

@alex-aff
Copy link

commented Aug 4, 2019

setTimeout function of Redis has deprecated so it should be replaced by expire function.
right now it is throwing following exception.

Redis::setTimeout() is deprecated

phpredis/phpredis#1572

  • PHP Version: >7.0
  • Redis Version: >5.0.0

@sergeyklay sergeyklay added the 4.0 label Aug 4, 2019

@sergeyklay sergeyklay added this to the 4.0.0 milestone Aug 4, 2019

@sergeyklay sergeyklay added the Bug - Low label Aug 4, 2019

@sergeyklay sergeyklay added this to To do in 4.0 Release via automation Aug 4, 2019

@CameronHall

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

We don't use setTimeout anywhere so this should be okay to close.

@sergeyklay

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

Fixed in the 4.0.x branch: #14284. Feel free to open a new issue if the problem appears again. Thank you for contributing.

@sergeyklay sergeyklay closed this Aug 7, 2019

4.0 Release automation moved this from To do to Done Aug 7, 2019

@alex-aff

This comment has been minimized.

Copy link
Author

commented Aug 7, 2019

@sergeyklay understood . However version v3.4.x still uses setTimeout(). Shouldn't we fix it for that version?
https://github.com/phalcon/cphalcon/blob/3.4.x/phalcon/cache/backend/redis.zep#L261

@jesugmz

This comment has been minimized.

Copy link

commented Aug 9, 2019

Same issue here for v3.4.4 and PhpRedis 5.0.2.
As v3.4.4 is the recomended version in https://phalconphp.com/en/ you should reconsider to reopen this issue @sergeyklay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.