Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide a persistent id for redis persistent connection #14334

Closed
lanlin opened this issue Aug 27, 2019 · 1 comment

Comments

@lanlin
Copy link
Contributor

@lanlin lanlin commented Aug 27, 2019

Description

we'd better provide a persistent id for Redis pconnect() method.

cause without it we can't switch between multiple databases in the same PHP process.

the data will always be saved to the last database without it.

as I know all Phalcon versions have this bug.

check this: https://github.com/phpredis/phpredis#pconnect-popen

Details

image

lanlin referenced this issue Aug 27, 2019
 add persistent id for Redis `pconnect()` method.
lanlin added a commit to lanlin/cphalcon that referenced this issue Aug 28, 2019
issue phalcon#14334

1. update changelog-4.0.md
2.ignore .idea
3. modified method `getAdapter()` in redis adapter
@niden niden added 4.0 and removed 4.1 labels Nov 3, 2019
@niden niden added this to To do in 4.0 Release via automation Nov 3, 2019
@niden

This comment has been minimized.

Copy link
Member

@niden niden commented Nov 3, 2019

Implemented

@niden niden closed this Nov 3, 2019
4.0 Release automation moved this from To do to Done Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.0 Release
  
Done
3 participants
You can’t perform that action at this time.