Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid returned value for Phalcon\Security::getSessionToken #14346

Closed
sergeyklay opened this issue Sep 2, 2019 · 0 comments
Labels
Projects
Milestone

Comments

@sergeyklay
Copy link
Member

@sergeyklay sergeyklay commented Sep 2, 2019

If you try to call $this->security->getSessionToken() in a controller w/o Security service initialization and declare(strict_types=1) you'll get:

Fatal error: Return value of Phalcon\Security::getSessionToken must be of type string, null returned

sergeyklay added a commit that referenced this issue Sep 2, 2019
@sergeyklay sergeyklay added this to the 4.0.0 milestone Sep 2, 2019
@sergeyklay sergeyklay added this to To do in 4.0 Release via automation Sep 2, 2019
sergeyklay added a commit to phalcon/vokuro that referenced this issue Sep 2, 2019
sergeyklay added a commit to phalcon/vokuro that referenced this issue Sep 2, 2019
sergeyklay added a commit to phalcon/vokuro that referenced this issue Sep 2, 2019
* Code cleanup

* Fixed security service initialization

* Improved CS

* Change getSessionToken() to getRequestToken() in CSRF forms

* Added workaround for phalcon/cphalcon#14346

* Do not use helper container()
@sergeyklay sergeyklay closed this Sep 2, 2019
4.0 Release automation moved this from To do to Done Sep 2, 2019
@niden niden referenced this issue Sep 3, 2019
3 of 5 tasks complete
niden added a commit that referenced this issue Sep 3, 2019
Added checks for request/session
Added optional services injection in the constructor
niden added a commit that referenced this issue Sep 3, 2019
niden added a commit that referenced this issue Sep 3, 2019
niden added a commit that referenced this issue Sep 3, 2019
niden added a commit that referenced this issue Sep 3, 2019
niden added a commit that referenced this issue Sep 3, 2019
niden added a commit that referenced this issue Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.0 Release
  
Done
1 participant
You can’t perform that action at this time.