Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up DI Classes #14359

Closed
niden opened this issue Sep 6, 2019 · 1 comment
Labels
Projects

Comments

@niden
Copy link
Member

@niden niden commented Sep 6, 2019

DI classes need to be tidied up

  • Rename abstract ones to Abstract*
  • Remove Plugin (duplicate class)
@niden niden added this to To do in 4.0 Release via automation Sep 6, 2019
@niden niden moved this from To do to In progress in 4.0 Release Sep 6, 2019
@niden niden mentioned this issue Sep 7, 2019
5 of 5 tasks complete
niden added a commit that referenced this issue Sep 7, 2019
…cphalcon into niden-T14359-tidy-up-di-classes

* 'T14359-tidy-up-di-classes' of https://github.com/niden/cphalcon:
  [#14359] - Fixing appveyor
  [#14359] - Updated changelog
  [#14359] - Renamed Injectable again
  [#14359] - Trying require
  [#14359] - trying a hack for codeception
  [#14359] - Renamed DI classes to abstract*
  [#14349] - Updated the changelog
  [#14349] - Adjusting the interfaces again
  [#14349] - Corrected class name
  [#14349] - Added _before in the helper class
  [#14349] - Fixing test
  [#14349] - Fixing tests
  [#14349] - Correcting tests
  [#14349] - Changed the interfaces and added escaper to the constructor
niden added a commit that referenced this issue Sep 7, 2019
* niden-T14359-tidy-up-di-classes:
  [#14359] - Fixing appveyor
  [#14359] - Updated changelog
  [#14359] - Renamed Injectable again
  [#14359] - Trying require
  [#14359] - trying a hack for codeception
  [#14359] - Renamed DI classes to abstract*
  [#14349] - Updated the changelog
  [#14349] - Adjusting the interfaces again
  [#14349] - Corrected class name
  [#14349] - Added _before in the helper class
  [#14349] - Fixing test
  [#14349] - Fixing tests
  [#14349] - Correcting tests
  [#14349] - Changed the interfaces and added escaper to the constructor
@niden

This comment has been minimized.

Copy link
Member Author

@niden niden commented Sep 7, 2019

Resolved

@niden niden closed this Sep 7, 2019
4.0 Release automation moved this from In progress to Done Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.0 Release
  
Done
1 participant
You can’t perform that action at this time.