Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Change property order in model->assign() #14386

Closed
ruudboon opened this issue Sep 16, 2019 · 1 comment
Assignees
Labels
Projects

Comments

@ruudboon
Copy link
Member

@ruudboon ruudboon commented Sep 16, 2019

Our current implementation looks like this:

assign(array $data, [mixed $dataColumnMap], [array $whiteList])

Often you will setup the column map in the model and don't specify it when assigning data to the model. When using the whitelist you should always put null on the dataColumnMap.
It would be me more logical to have the whitelist first.

assign(array $data, [array $whiteList], [mixed $dataColumnMap])
@ruudboon ruudboon added this to To do in 4.0 Release via automation Sep 16, 2019
@ruudboon ruudboon self-assigned this Sep 16, 2019
@ruudboon ruudboon moved this from To do to In progress in 4.0 Release Sep 16, 2019
@ruudboon ruudboon referenced this issue Sep 16, 2019
3 of 5 tasks complete
ruudboon added a commit to ruudboon/docs that referenced this issue Sep 16, 2019
niden added a commit to phalcon/docs that referenced this issue Sep 16, 2019
@niden

This comment has been minimized.

Copy link
Member

@niden niden commented Sep 16, 2019

Resolved

@niden niden closed this Sep 16, 2019
4.0 Release automation moved this from In progress to Done Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.0 Release
  
Done
2 participants
You can’t perform that action at this time.