Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Transactions not working on the Logger component #14514

Closed
diplopito opened this issue Nov 4, 2019 · 3 comments
Closed

[BUG]: Transactions not working on the Logger component #14514

diplopito opened this issue Nov 4, 2019 · 3 comments
Assignees
Labels
Projects

Comments

@diplopito
Copy link

@diplopito diplopito commented Nov 4, 2019

Phalcon v3.x had support for transactions in the Logger component but they got lost in v4. Would be ideal to bring them back.

@niden niden added 4.0 Bug - Low and removed Feature - NFR labels Nov 4, 2019
@niden niden added this to To do in 4.0 Release via automation Nov 4, 2019
@niden niden changed the title [NFR]: Bring back transactions support to Logger component [BUG]: Transactions not working on the Logger component Nov 4, 2019
@niden

This comment has been minimized.

Copy link
Member

@niden niden commented Nov 4, 2019

In the logger for v3 we used to have transactional logging with $logger->begin() and $logger->commit()`

Although those methods exist in each adapter, there is no real way to access an adapter as an object from the logger so that you can call begin or commit

We need to add something like this $logger->getAdapter('prod')->begin()

@niden niden added the Docs needed label Nov 4, 2019
@niden niden self-assigned this Nov 4, 2019
@niden niden mentioned this issue Nov 6, 2019
5 of 5 tasks complete
@niden niden removed the Docs needed label Nov 6, 2019
niden added a commit that referenced this issue Nov 6, 2019
@niden

This comment has been minimized.

Copy link
Member

@niden niden commented Nov 6, 2019

Resolved in #14516

@niden niden closed this Nov 6, 2019
4.0 Release automation moved this from To do to Done Nov 6, 2019
@niden

This comment has been minimized.

Copy link
Member

@niden niden commented Nov 6, 2019

Thank you @diplopito

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.0 Release
  
Done
2 participants
You can’t perform that action at this time.