Skip to content

/cphalcon

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Request::hasFiles renamed #14519

Closed
niden opened this issue Nov 7, 2019 · 2 comments
Closed

[BUG]: Request::hasFiles renamed #14519

niden opened this issue Nov 7, 2019 · 2 comments
Labels
4.0 Breaks BC Bug - Medium
Projects
4.0 Release

Comments

@niden
Copy link
Member

@niden niden commented Nov 7, 2019

Phalcon\Http\Request::hasFiles returns the number of files available.

  • Method needs to be renamed to numFiles and hasFiles to return boolean
@niden niden added this to To do in 4.0 Release via automation Nov 7, 2019
@niden niden mentioned this issue Nov 7, 2019
Merged
5 of 5 tasks complete
@niden

This comment has been minimized.

Sign in to view
Copy link
Member Author

@niden niden commented Nov 7, 2019

Ref: #12687
@niden niden removed the Docs needed label Nov 7, 2019
niden added a commit that referenced this issue Nov 7, 2019
@niden
[#14519] - Corrected hasFiles; added numFiles
86d15cf
niden added a commit that referenced this issue Nov 7, 2019
@niden
[#14519] - Added tests
6c63fe3
niden added a commit that referenced this issue Nov 7, 2019
@niden
[#14519] - Updated changelog
ce2b733
niden added a commit that referenced this issue Nov 7, 2019
@niden
[#14519] - Corrected test and emails
Loading status checks…
033c708
@niden

This comment has been minimized.

Sign in to view
Copy link
Member Author

@niden niden commented Nov 7, 2019

Resolved in #14520
@niden niden closed this Nov 7, 2019
4.0 Release automation moved this from To do to Done Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.0 Breaks BC Bug - Medium
Projects
4.0 Release
  
Done
Milestone
No milestone
1 participant
@niden
You can’t perform that action at this time.