Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Compile error for v4.0.0-RC.R3 on macOS 10.15.1 and PHP 7.4.0 #14577

Closed
panosru opened this issue Dec 3, 2019 · 25 comments
Closed

[BUG]: Compile error for v4.0.0-RC.R3 on macOS 10.15.1 and PHP 7.4.0 #14577

panosru opened this issue Dec 3, 2019 · 25 comments
Assignees

Comments

@panosru
Copy link

@panosru panosru commented Dec 3, 2019

It seems that there is an issue with libtool version that prevents the compiler to run properly.

image

image

@ruudboon ruudboon added the 4.0 label Dec 4, 2019
@ruudboon

This comment has been minimized.

Copy link
Member

@ruudboon ruudboon commented Dec 4, 2019

We're gonna have a look at this. For the time being you can also use MacPorts to install V4. https://docs.phalcon.io/4.0/en/installation#macosx-using-macports

@panosru

This comment has been minimized.

Copy link
Author

@panosru panosru commented Dec 4, 2019

Thank you for the reply @ruudboon, I'm using brew, and I prefer to not mix package managers; thus I will wait for a fix, when there will be one, and manually install it :)

@ruudboon

This comment has been minimized.

Copy link
Member

@ruudboon ruudboon commented Dec 4, 2019

@panosru Is this a clean checkout of the repo, or did you builded in this dir on an older os before?
Could you otherwise try a clean build.

cd cphalcon/
git checkout tags/v4.0.0-rc.3 ./
zephir fullclean
zephir compile
cd ext
phpize
./configure
make && make install

If it's already a clean checkout I can check this behaviour probably during the weekend. Need to borrow a MacBook with Catalina (Can't upgrade yet due to external hardware)

@panosru

This comment has been minimized.

Copy link
Author

@panosru panosru commented Dec 4, 2019

@ruudboon thanks for the instructions! Although I'm sure I had the correct tag and I did everything on clean clone, I followed your instructions to make sure that it wasn't an issue on my end.

The result was the same, I will post you some screenshots that might help you debug that issue.

image
image
image

If you need me to try anything, just let me know

Thanks!

UPDATE:
The contents of /Users/panosru/.bin/php can be found here:

#!/bin/sh

for arg in $@
do
  if [ $arg = "-d" ]
  then
    PHPDEBUG='-d xdebug.idekey=PHPSTORM -d xdebug.remote_autostart=1'
    #shift
    if [ ${@:$(($#))} = "-d" ]
    then
      set -- "${@:1:$(($#-1))}"
    fi
  fi
done
"${PHP_PATH}/php" $PHPDEBUG "$@"

Do you think that this might causing the issue? I used to compile Phalcon without any issue before PHP 7.4 though

UPDATE2:
I tried it without my custom php binary but I got the same issue.
Ignore the "Trap 6" error, it was caused by swoole extension which I disabled for time being.

@sergeyklay

This comment has been minimized.

Copy link
Member

@sergeyklay sergeyklay commented Dec 4, 2019

Just installed Phalcon from 4.0.x branch on macOS

asciicast

@panosru

This comment has been minimized.

Copy link
Author

@panosru panosru commented Dec 4, 2019

@sergeyklay I'm on PHP 7.4.0 & macOS 10.15.1

before PHP 7.4.0 I was also able to install Phalcon without any issue.

@sergeyklay

This comment has been minimized.

Copy link
Member

@sergeyklay sergeyklay commented Dec 4, 2019

I just compiled PHP 7.4.0 from source and was able to reproduce the issue

@ruudboon ruudboon added this to To do in 4.0.0 Release via automation Dec 4, 2019
Zanadar added a commit to cloudfoundry/buildpacks-ci that referenced this issue Dec 6, 2019
@ruudboon ruudboon moved this from To do to In progress in 4.0.0 Release Dec 7, 2019
@sergeyklay

This comment has been minimized.

Copy link
Member

@sergeyklay sergeyklay commented Dec 8, 2019

Status update: I was able to compile and install Phalcon from 4.0.x branch on Debian GNU/Linux 10 using PHP 7.4.0 without any issue.

@panosru

This comment has been minimized.

Copy link
Author

@panosru panosru commented Dec 8, 2019

I compiled it yesterday in my debian docker image and it worked fine, but on macOS I cannot install it, I'm getting the errors posted in my screenshots...

@sergeyklay sergeyklay mentioned this issue Dec 8, 2019
2 of 3 tasks complete
@ruudboon

This comment has been minimized.

Copy link
Member

@ruudboon ruudboon commented Dec 8, 2019

Tested with from Zephir master and works fine now.

@panosru

This comment has been minimized.

Copy link
Author

@panosru panosru commented Dec 8, 2019

@ruudboon I have tried it with both Zephir 0.12.12 and 0.12.13, I still get those errors on macOS:

image

@ruudboon

This comment has been minimized.

Copy link
Member

@ruudboon ruudboon commented Dec 8, 2019

@panosru did you do fullclean ?
0.12.13 isn’t released yet (will happen any moment). When I tested it I used the development branch. Master is merged just moment ago

@panosru

This comment has been minimized.

Copy link
Author

@panosru panosru commented Dec 8, 2019

@ruudboon of course, I followed the procedure you posted earlier... it is working for you in macOS? :/

@ruudboon

This comment has been minimized.

Copy link
Member

@ruudboon ruudboon commented Dec 8, 2019

@panosru see updated comment.

@panosru

This comment has been minimized.

Copy link
Author

@panosru panosru commented Dec 8, 2019

@ruudboon I have checked out the master branch of zephir (phalcon/zephir@a4e9535), then I followed your procedure but when I run make I'm getting the following:

/bin/sh /Volumes/Projects/_dev/cphalcon/ext/libtool --mode=compile cc  -I. -I/Volumes/Projects/_dev/cphalcon/ext -DPHP_ATOM_INC -I/Volumes/Projects/_dev/cphalcon/ext/include -I/Volumes/Projects/_dev/cphalcon/ext/main -I/Volumes/Projects/_dev/cphalcon/ext -I/usr/local/Cellar/php/7.4.0/include/php -I/usr/local/Cellar/php/7.4.0/include/php/main -I/usr/local/Cellar/php/7.4.0/include/php/TSRM -I/usr/local/Cellar/php/7.4.0/include/php/Zend -I/usr/local/Cellar/php/7.4.0/include/php/ext -I/usr/local/Cellar/php/7.4.0/include/php/ext/date/lib  -DHAVE_CONFIG_H  -g -O2   -c /Volumes/Projects/_dev/cphalcon/ext/phalcon/url/utils.c -o phalcon/url/utils.lo
 cc -I. -I/Volumes/Projects/_dev/cphalcon/ext -DPHP_ATOM_INC -I/Volumes/Projects/_dev/cphalcon/ext/include -I/Volumes/Projects/_dev/cphalcon/ext/main -I/Volumes/Projects/_dev/cphalcon/ext -I/usr/local/Cellar/php/7.4.0/include/php -I/usr/local/Cellar/php/7.4.0/include/php/main -I/usr/local/Cellar/php/7.4.0/include/php/TSRM -I/usr/local/Cellar/php/7.4.0/include/php/Zend -I/usr/local/Cellar/php/7.4.0/include/php/ext -I/usr/local/Cellar/php/7.4.0/include/php/ext/date/lib -DHAVE_CONFIG_H -g -O2 -c /Volumes/Projects/_dev/cphalcon/ext/phalcon/url/utils.c  -fno-common -DPIC -o phalcon/url/.libs/utils.o
In file included from /Volumes/Projects/_dev/cphalcon/ext/phalcon/url/utils.c:17:
In file included from ./phalcon.h:36:
./phalcon/http/message/abstractmessage.zep.h:157:47: warning: \U used with no following hex digits; treating as '\' followed by identifier [-Wunicode]
        ZEND_ARG_OBJ_INFO(0, uri, Psr\\Http\\Message\\UriInterface, 0)
                                                     ^
In file included from /Volumes/Projects/_dev/cphalcon/ext/phalcon/url/utils.c:17:
In file included from ./phalcon.h:70:
./phalcon/http/message/abstractrequest.zep.h:50:47: warning: \U used with no following hex digits; treating as '\' followed by identifier [-Wunicode]
        ZEND_ARG_OBJ_INFO(0, uri, Psr\\Http\\Message\\UriInterface, 0)
                                                     ^
./phalcon/http/message/abstractrequest.zep.h:63:122: warning: \U used with no following hex digits; treating as '\' followed by identifier [-Wunicode]
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_phalcon_http_message_abstractrequest_processuri, 0, 1, Psr\\Http\\Message\\UriInterface, 0)
                                                                                                                         ^
In file included from /Volumes/Projects/_dev/cphalcon/ext/phalcon/url/utils.c:17:
In file included from ./phalcon.h:143:
./phalcon/url/urlinterface.zep.h:35:100: warning: \U used with no following hex digits; treating as '\' followed by identifier [-Wunicode]
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_phalcon_url_urlinterface_setbasepath, 0, 1, Phalcon\\Url\\UrlInterface, 0)
                                                                                                   ^
./phalcon/url/urlinterface.zep.h:35:105: warning: \U used with no following hex digits; treating as '\' followed by identifier [-Wunicode]
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_phalcon_url_urlinterface_setbasepath, 0, 1, Phalcon\\Url\\UrlInterface, 0)
                                                                                                        ^
./phalcon/url/urlinterface.zep.h:47:99: warning: \U used with no following hex digits; treating as '\' followed by identifier [-Wunicode]
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_phalcon_url_urlinterface_setbaseuri, 0, 1, Phalcon\\Url\\UrlInterface, 0)
                                                                                                  ^
./phalcon/url/urlinterface.zep.h:47:104: warning: \U used with no following hex digits; treating as '\' followed by identifier [-Wunicode]
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_phalcon_url_urlinterface_setbaseuri, 0, 1, Phalcon\\Url\\UrlInterface, 0)
                                                                                                       ^
In file included from /Volumes/Projects/_dev/cphalcon/ext/phalcon/url/utils.c:17:
In file included from ./phalcon.h:314:
./phalcon/http/message/serverrequestfactory.zep.h:106:139: warning: \U used with no following hex digits; treating as '\' followed by identifier [-Wunicode]
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_phalcon_http_message_serverrequestfactory_createuploadedfile, 0, 1, Phalcon\\Http\\Message\\UploadedFile, 0)
                                                                                                                                          ^
./phalcon/http/message/serverrequestfactory.zep.h:168:129: warning: \U used with no following hex digits; treating as '\' followed by identifier [-Wunicode]
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_phalcon_http_message_serverrequestfactory_parseuri, 0, 2, Phalcon\\Http\\Message\\Uri, 0)
                                                                                                                                ^
In file included from /Volumes/Projects/_dev/cphalcon/ext/phalcon/url/utils.c:17:
In file included from ./phalcon.h:320:
./phalcon/http/message/uploadedfilefactory.zep.h:9:134: warning: \U used with no following hex digits; treating as '\' followed by identifier [-Wunicode]
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_phalcon_http_message_uploadedfilefactory_createuploadedfile, 0, 1, Psr\\Http\\Message\\UploadedFileInterface, 0)
                                                                                                                                     ^
In file included from /Volumes/Projects/_dev/cphalcon/ext/phalcon/url/utils.c:17:
In file included from ./phalcon.h:321:
./phalcon/http/message/uri.zep.h:61:116: warning: \U used with no following hex digits; treating as '\' followed by identifier [-Wunicode]
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_phalcon_http_message_uri_withfragment, 0, 1, Phalcon\\Http\\Message\\Uri, 0)
                                                                                                                   ^
./phalcon/http/message/uri.zep.h:69:112: warning: \U used with no following hex digits; treating as '\' followed by identifier [-Wunicode]
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_phalcon_http_message_uri_withpath, 0, 1, Phalcon\\Http\\Message\\Uri, 0)
                                                                                                               ^
./phalcon/http/message/uri.zep.h:77:112: warning: \U used with no following hex digits; treating as '\' followed by identifier [-Wunicode]
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_phalcon_http_message_uri_withport, 0, 1, Phalcon\\Http\\Message\\Uri, 0)
                                                                                                               ^
./phalcon/http/message/uri.zep.h:85:113: warning: \U used with no following hex digits; treating as '\' followed by identifier [-Wunicode]
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_phalcon_http_message_uri_withquery, 0, 1, Phalcon\\Http\\Message\\Uri, 0)
                                                                                                                ^
./phalcon/http/message/uri.zep.h:93:114: warning: \U used with no following hex digits; treating as '\' followed by identifier [-Wunicode]
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_phalcon_http_message_uri_withscheme, 0, 1, Phalcon\\Http\\Message\\Uri, 0)
                                                                                                                 ^
./phalcon/http/message/uri.zep.h:101:116: warning: \U used with no following hex digits; treating as '\' followed by identifier [-Wunicode]
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_phalcon_http_message_uri_withuserinfo, 0, 1, Phalcon\\Http\\Message\\Uri, 0)
                                                                                                                   ^
./phalcon/http/message/uri.zep.h:110:112: warning: \U used with no following hex digits; treating as '\' followed by identifier [-Wunicode]
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_phalcon_http_message_uri_withhost, 0, 1, Phalcon\\Http\\Message\\Uri, 0)
                                                                                                               ^
In file included from /Volumes/Projects/_dev/cphalcon/ext/phalcon/url/utils.c:17:
In file included from ./phalcon.h:322:
./phalcon/http/message/urifactory.zep.h:9:116: warning: \U used with no following hex digits; treating as '\' followed by identifier [-Wunicode]
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_phalcon_http_message_urifactory_createuri, 0, 0, Psr\\Http\\Message\\UriInterface, 0)
                                                                                                                   ^
In file included from /Volumes/Projects/_dev/cphalcon/ext/phalcon/url/utils.c:17:
In file included from ./phalcon.h:426:
./phalcon/tag.zep.h:245:89: warning: \U used with no following hex digits; treating as '\' followed by identifier [-Wunicode]
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_phalcon_tag_geturlservice, 0, 0, Phalcon\\Url\\UrlInterface, 0)
                                                                                        ^
./phalcon/tag.zep.h:245:94: warning: \U used with no following hex digits; treating as '\' followed by identifier [-Wunicode]
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_phalcon_tag_geturlservice, 0, 0, Phalcon\\Url\\UrlInterface, 0)
                                                                                             ^
In file included from /Volumes/Projects/_dev/cphalcon/ext/phalcon/url/utils.c:17:
In file included from ./phalcon.h:438:
./phalcon/url.zep.h:66:87: warning: \U used with no following hex digits; treating as '\' followed by identifier [-Wunicode]
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_phalcon_url_setbasepath, 0, 1, Phalcon\\Url\\UrlInterface, 0)
                                                                                      ^
./phalcon/url.zep.h:66:92: warning: \U used with no following hex digits; treating as '\' followed by identifier [-Wunicode]
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_phalcon_url_setbasepath, 0, 1, Phalcon\\Url\\UrlInterface, 0)
                                                                                           ^
./phalcon/url.zep.h:78:86: warning: \U used with no following hex digits; treating as '\' followed by identifier [-Wunicode]
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_phalcon_url_setbaseuri, 0, 1, Phalcon\\Url\\UrlInterface, 0)
                                                                                     ^
./phalcon/url.zep.h:78:91: warning: \U used with no following hex digits; treating as '\' followed by identifier [-Wunicode]
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_phalcon_url_setbaseuri, 0, 1, Phalcon\\Url\\UrlInterface, 0)
                                                                                          ^
./phalcon/url.zep.h:90:92: warning: \U used with no following hex digits; treating as '\' followed by identifier [-Wunicode]
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_phalcon_url_setstaticbaseuri, 0, 1, Phalcon\\Url\\UrlInterface, 0)
                                                                                           ^
./phalcon/url.zep.h:90:97: warning: \U used with no following hex digits; treating as '\' followed by identifier [-Wunicode]
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_phalcon_url_setstaticbaseuri, 0, 1, Phalcon\\Url\\UrlInterface, 0)
                                                                                                ^
/Volumes/Projects/_dev/cphalcon/ext/phalcon/url/utils.c:147:7: error: expected ';' after expression
        ulong position = 1;
             ^
             ;
/Volumes/Projects/_dev/cphalcon/ext/phalcon/url/utils.c:147:2: error: use of undeclared identifier 'ulong'
        ulong position = 1;
        ^
/Volumes/Projects/_dev/cphalcon/ext/phalcon/url/utils.c:147:8: error: use of undeclared identifier 'position'
        ulong position = 1;
              ^
/Volumes/Projects/_dev/cphalcon/ext/phalcon/url/utils.c:196:66: error: use of undeclared identifier 'position'
                                                        replace = phalcon_replace_marker(1, paths, replacements, &position, cursor, marker);
                                                                                                                  ^
/Volumes/Projects/_dev/cphalcon/ext/phalcon/url/utils.c:230:66: error: use of undeclared identifier 'position'
                                                        replace = phalcon_replace_marker(0, paths, replacements, &position, cursor, marker);
                                                                                                                  ^
/Volumes/Projects/_dev/cphalcon/ext/phalcon/url/utils.c:256:65: error: use of undeclared identifier 'position'
                                                replace = phalcon_replace_marker(0, paths, replacements, &position, cursor, marker);
                                                                                                          ^
26 warnings and 6 errors generated.
make: *** [phalcon/url/utils.lo] Error 1

Could it be something related to my end? I didn't had any issue with PHP 7.3.12, when I run brew update && brew upgrade a few days ago, it updated to PHP 7.4.0, since then I'm unable to install phalcon, amqp, and msgpack and also I'm getting errors with swoole extension. So, quite a lot of issue with PHP 7.4 so far on macOS...

@ruudboon ruudboon mentioned this issue Dec 8, 2019
2 of 5 tasks complete
@sergeyklay

This comment has been minimized.

Copy link
Member

@sergeyklay sergeyklay commented Dec 8, 2019

@panosru The issue is described in #14600 (comment)

@panosru

This comment has been minimized.

Copy link
Author

@panosru panosru commented Dec 8, 2019

@sergeyklay I read your comment here #14600 (comment) and I replaced everything in ext/ directory:

image

For ulong under ext/ directory I couldn't find any match, there where all already set to zend_ulong.

Now make produces the following errors:

/bin/sh /Volumes/Projects/_dev/cphalcon/ext/libtool --mode=compile cc  -I. -I/Volumes/Projects/_dev/cphalcon/ext -DPHP_ATOM_INC -I/Volumes/Projects/_dev/cphalcon/ext/include -I/Volumes/Projects/_dev/cphalcon/ext/main -I/Volumes/Projects/_dev/cphalcon/ext -I/usr/local/Cellar/php/7.4.0/include/php -I/usr/local/Cellar/php/7.4.0/include/php/main -I/usr/local/Cellar/php/7.4.0/include/php/TSRM -I/usr/local/Cellar/php/7.4.0/include/php/Zend -I/usr/local/Cellar/php/7.4.0/include/php/ext -I/usr/local/Cellar/php/7.4.0/include/php/ext/date/lib  -DHAVE_CONFIG_H  -g -O2   -c /Volumes/Projects/_dev/cphalcon/ext/kernel/object.c -o kernel/object.lo
 cc -I. -I/Volumes/Projects/_dev/cphalcon/ext -DPHP_ATOM_INC -I/Volumes/Projects/_dev/cphalcon/ext/include -I/Volumes/Projects/_dev/cphalcon/ext/main -I/Volumes/Projects/_dev/cphalcon/ext -I/usr/local/Cellar/php/7.4.0/include/php -I/usr/local/Cellar/php/7.4.0/include/php/main -I/usr/local/Cellar/php/7.4.0/include/php/TSRM -I/usr/local/Cellar/php/7.4.0/include/php/Zend -I/usr/local/Cellar/php/7.4.0/include/php/ext -I/usr/local/Cellar/php/7.4.0/include/php/ext/date/lib -DHAVE_CONFIG_H -g -O2 -c /Volumes/Projects/_dev/cphalcon/ext/kernel/object.c  -fno-common -DPIC -o kernel/.libs/object.o
In file included from /Volumes/Projects/_dev/cphalcon/ext/kernel/object.c:22:
In file included from ./kernel/main.h:53:
./kernel/exception.h:59:79: error: unknown type name 'zend_uint'
void zephir_throw_exception_string(zend_class_entry *ce, const char *message, zend_uint message_len);
                                                                              ^
./kernel/main.h:40:20: note: expanded from macro 'zend_uint'
 #define zend_uint zend_uint
                   ^
In file included from /Volumes/Projects/_dev/cphalcon/ext/kernel/object.c:22:
In file included from ./kernel/main.h:53:
./kernel/exception.h:60:67: error: unknown type name 'zend_uint'
void zephir_throw_exception_debug(zval *object, const char *file, zend_uint line);
                                                                  ^
./kernel/main.h:40:20: note: expanded from macro 'zend_uint'
 #define zend_uint zend_uint
                   ^
In file included from /Volumes/Projects/_dev/cphalcon/ext/kernel/object.c:22:
In file included from ./kernel/main.h:53:
./kernel/exception.h:62:85: error: unknown type name 'zend_uint'
void zephir_throw_exception_string_debug(zend_class_entry *ce, const char *message, zend_uint message_len, const char *file, zend_uint line);
                                                                                    ^
./kernel/main.h:40:20: note: expanded from macro 'zend_uint'
 #define zend_uint zend_uint
                   ^
In file included from /Volumes/Projects/_dev/cphalcon/ext/kernel/object.c:22:
In file included from ./kernel/main.h:53:
./kernel/exception.h:62:126: error: unknown type name 'zend_uint'
void zephir_throw_exception_string_debug(zend_class_entry *ce, const char *message, zend_uint message_len, const char *file, zend_uint line);
                                                                                                                             ^
./kernel/main.h:40:20: note: expanded from macro 'zend_uint'
 #define zend_uint zend_uint
                   ^
In file included from /Volumes/Projects/_dev/cphalcon/ext/kernel/object.c:24:
./kernel/object.h:45:81: error: unknown type name 'zend_uint'
int zephir_read_property(zval *result, zval *object, const char *property_name, zend_uint property_length, int silent);
                                                                                ^
./kernel/main.h:40:20: note: expanded from macro 'zend_uint'
 #define zend_uint zend_uint
                   ^
In file included from /Volumes/Projects/_dev/cphalcon/ext/kernel/object.c:24:
./kernel/object.h:48:82: error: unknown type name 'zend_uint'
int zephir_fetch_property(zval *result, zval *object, const char *property_name, zend_uint property_length, int silent);
                                                                                 ^
./kernel/main.h:40:20: note: expanded from macro 'zend_uint'
 #define zend_uint zend_uint
                   ^
In file included from /Volumes/Projects/_dev/cphalcon/ext/kernel/object.c:24:
./kernel/object.h:56:70: error: unknown type name 'zend_uint'
int zephir_update_property_array(zval *object, const char *property, zend_uint property_length, const zval *index, zval *value);
                                                                     ^
./kernel/main.h:40:20: note: expanded from macro 'zend_uint'
 #define zend_uint zend_uint
                   ^
In file included from /Volumes/Projects/_dev/cphalcon/ext/kernel/object.c:24:
./kernel/object.h:59:76: error: unknown type name 'zend_uint'
int zephir_update_property_array_multi(zval *object, const char *property, zend_uint property_length, zval *value, const char *types, int types_length, int types_count, ...);
                                                                           ^
./kernel/main.h:40:20: note: expanded from macro 'zend_uint'
 #define zend_uint zend_uint
                   ^
In file included from /Volumes/Projects/_dev/cphalcon/ext/kernel/object.c:24:
./kernel/object.h:67:82: error: unknown type name 'zend_uint32_t'; did you mean 'zend_uintptr_t'?
int zephir_update_static_property_ce(zend_class_entry *ce, const char *property, zend_uint32_t len, zval *value);
                                                                                 ^~~~~~~~~~~~~
                                                                                 zend_uintptr_t
/usr/local/Cellar/php/7.4.0/include/php/Zend/zend_types.h:72:19: note: 'zend_uintptr_t' declared here
typedef uintptr_t zend_uintptr_t;
                  ^
In file included from /Volumes/Projects/_dev/cphalcon/ext/kernel/object.c:24:
./kernel/object.h:68:94: error: unknown type name 'zend_uint'
int zephir_update_static_property_array_multi_ce(zend_class_entry *ce, const char *property, zend_uint property_length, zval *value, const char *types, int types_length, int types_count, ...);
                                                                                             ^
./kernel/main.h:40:20: note: expanded from macro 'zend_uint'
 #define zend_uint zend_uint
                   ^
In file included from /Volumes/Projects/_dev/cphalcon/ext/kernel/object.c:24:
./kernel/object.h:71:113: error: unknown type name 'zend_uint'
int zephir_create_closure_ex(zval *return_value, zval *this_ptr, zend_class_entry *ce, const char *method_name, zend_uint method_length);
                                                                                                                ^
./kernel/main.h:40:20: note: expanded from macro 'zend_uint'
 #define zend_uint zend_uint
                   ^
In file included from /Volumes/Projects/_dev/cphalcon/ext/kernel/object.c:26:
./kernel/fcall.h:292:77: error: unknown type name 'zend_uint'
int zephir_call_func_aparams(zval *return_value_ptr, const char *func_name, zend_uint func_length,
                                                                            ^
./kernel/main.h:40:20: note: expanded from macro 'zend_uint'
 #define zend_uint zend_uint
                   ^
In file included from /Volumes/Projects/_dev/cphalcon/ext/kernel/object.c:26:
./kernel/fcall.h:312:20: error: unknown type name 'zend_uint'
        const char *func, zend_uint func_len, zephir_fcall_cache_entry **cache_entry, int cache_slot, zend_uint param_count, zval **params)
                          ^
./kernel/main.h:40:20: note: expanded from macro 'zend_uint'
 #define zend_uint zend_uint
                   ^
In file included from /Volumes/Projects/_dev/cphalcon/ext/kernel/object.c:26:
./kernel/fcall.h:312:96: error: unknown type name 'zend_uint'
        const char *func, zend_uint func_len, zephir_fcall_cache_entry **cache_entry, int cache_slot, zend_uint param_count, zval **params)
                                                                                                      ^
./kernel/main.h:40:20: note: expanded from macro 'zend_uint'
 #define zend_uint zend_uint
                   ^
In file included from /Volumes/Projects/_dev/cphalcon/ext/kernel/object.c:26:
./kernel/fcall.h:340:70: error: unknown type name 'zend_uint'
        zval *func, zephir_fcall_cache_entry **cache_entry, int cache_slot, zend_uint param_count, zval **params)
                                                                            ^
./kernel/main.h:40:20: note: expanded from macro 'zend_uint'
 #define zend_uint zend_uint
                   ^
In file included from /Volumes/Projects/_dev/cphalcon/ext/kernel/object.c:26:
./kernel/fcall.h:369:27: error: unknown type name 'zend_uint'
        const char *method_name, zend_uint method_len,
                                 ^
./kernel/main.h:40:20: note: expanded from macro 'zend_uint'
 #define zend_uint zend_uint
                   ^
In file included from /Volumes/Projects/_dev/cphalcon/ext/kernel/object.c:27:
./kernel/array.h:21:62: error: unknown type name 'zend_uint'
void ZEPHIR_FASTCALL zephir_create_array(zval *return_value, zend_uint size, int initialize);
                                                             ^
./kernel/main.h:40:20: note: expanded from macro 'zend_uint'
 #define zend_uint zend_uint
                   ^
In file included from /Volumes/Projects/_dev/cphalcon/ext/kernel/object.c:27:
./kernel/array.h:31:82: error: unknown type name 'zend_uint'
int zephir_array_isset_string_fetch(zval *fetched, const zval *arr, char *index, zend_uint index_length, int readonly);
                                                                                 ^
./kernel/main.h:40:20: note: expanded from macro 'zend_uint'
 #define zend_uint zend_uint
                   ^
In file included from /Volumes/Projects/_dev/cphalcon/ext/kernel/object.c:27:
./kernel/array.h:37:83: error: unknown type name 'zend_uint'
int ZEPHIR_FASTCALL zephir_array_isset_string(const zval *arr, const char *index, zend_uint index_length);
                                                                                  ^
./kernel/main.h:40:20: note: expanded from macro 'zend_uint'
 #define zend_uint zend_uint
                   ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make: *** [kernel/object.lo] Error 1
@sergeyklay

This comment has been minimized.

Copy link
Member

@sergeyklay sergeyklay commented Dec 8, 2019

@panosru remove this

#ifndef zend_uint
 #define zend_uint uint
#endif

from ./kernel/main.h and try again

@panosru

This comment has been minimized.

Copy link
Author

@panosru panosru commented Dec 8, 2019

@sergeyklay damn, that was a huge mistake from my side! Thanks for pointing out!

All is left now is this:
image

Should I replace zend_uintptr32_t with zend_uintptr_t on ./kernel/object.h?

@sergeyklay

This comment has been minimized.

Copy link
Member

@sergeyklay sergeyklay commented Dec 8, 2019

@panosru Return back zend_uintptr32_t => uint32_t

@sergeyklay

This comment has been minimized.

Copy link
Member

@sergeyklay sergeyklay commented Dec 8, 2019

- int zephir_update_static_property_ce(zend_class_entry *ce, const char *property_name, zend_uintptr32_t property_length, zval *value)
+ int zephir_update_static_property_ce(zend_class_entry *ce, const char *property_name, uint32_t property_length, zval *value)
@panosru

This comment has been minimized.

Copy link
Author

@panosru panosru commented Dec 8, 2019

@sergeyklay Thanks for the support!

I have applied that change, then I run make and now I'm getting that:
image

Did you guys faced those issues on macOS as well or is it me? :/

@sergeyklay

This comment has been minimized.

Copy link
Member

@sergeyklay sergeyklay commented Dec 8, 2019

It it is just on your machine. Do you see ulong position = 1; in the output? As I described in the #14600

You have to regenerate C-code, then find all uint type definitions and replace they by zend_uint. The same for ulong => zend_ulong

@panosru

This comment has been minimized.

Copy link
Author

@panosru panosru commented Dec 8, 2019

@sergeyklay yes, in file utils.c on line 147 I can now see ulong position = 1;, I replaced it with zend_ulong it seems that for some reason atom (editor) wasn't showing the correct content of the file.

Now it works fine :) Thanks a lot!

@panosru panosru closed this Dec 8, 2019
4.0.0 Release automation moved this from In progress to Done Dec 8, 2019
@ruudboon

This comment has been minimized.

Copy link
Member

@ruudboon ruudboon commented Dec 8, 2019

@panosru thnx for reporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.0.0 Release
  
Done
4 participants
You can’t perform that action at this time.