Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Container is not passed to the autoloader registration method. #14787

Closed
TimurFlush opened this issue Jan 29, 2020 · 5 comments
Closed

[BUG]: Container is not passed to the autoloader registration method. #14787

TimurFlush opened this issue Jan 29, 2020 · 5 comments

Comments

@TimurFlush
Copy link

@TimurFlush TimurFlush commented Jan 29, 2020

Hello there!

I was wondering if it is a bug or not? (Please see the link)

moduleObject->registerAutoloaders();

Why is the current container not passed to the module's autoloader registration method?
I noticed that this is only relevant for the application Phalcon\Cli\Console.

Details

  • Phalcon version: ^4
@niden

This comment has been minimized.

Copy link
Member

@niden niden commented Jan 29, 2020

Bug for sure.

@niden niden added this to Current Sprint (Ends February 7th) in Phalcon Roadmap Jan 29, 2020
@TimurFlush

This comment has been minimized.

Copy link
Author

@TimurFlush TimurFlush commented Jan 29, 2020

Thank you, @niden. Maybe in this situation, make the container argument mandatory in the registerAutoloaders () method?

@niden

This comment has been minimized.

Copy link
Member

@niden niden commented Jan 30, 2020

@TimurFlush Unfortunately we cannot do that because it will break the interface and we are only allowed to do that during major versions i.e. v5. We can correct this however by just injecting the container in the place you mentioned.

If it not too much trouble can you send a PR for this? If not I will try and get that sorted out

@TimurFlush TimurFlush mentioned this issue Jan 30, 2020
3 of 3 tasks complete
@TimurFlush

This comment has been minimized.

Copy link
Author

@TimurFlush TimurFlush commented Jan 30, 2020

@niden , it's clear
Please check: #14790

niden added a commit that referenced this issue Jan 30, 2020
@niden

This comment has been minimized.

Copy link
Member

@niden niden commented Jan 30, 2020

Resolved in #14790 Thank you!

@niden niden closed this Jan 30, 2020
Phalcon Roadmap automation moved this from Current Sprint (Ends February 7th) to Implemented Jan 30, 2020
@niden niden moved this from Implemented to Released in Phalcon Roadmap Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Phalcon Roadmap
  
Released
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.