Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFR] Volt Compiler - beforeCompile, afterCompile events #2182

Closed
naNuke opened this Issue Mar 17, 2014 · 1 comment

Comments

Projects
3 participants
@naNuke
Copy link

naNuke commented Mar 17, 2014

Hello, I would like to request relatively simple feature (I think) and that is beforeCompile and afterCompile events for volt compiler.

View component atm supports beforeRender and afterRender events which can be called everytime a view file is being rendered.

The idea behind beforeCompile and afterCompile is to enable possibility of modifying the compiled view file before it is saved to hdd and not during every request like beforeRender and afterRender.

Thank you for considering this.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@niden niden added Unassigned and removed Unassigned labels Apr 3, 2014

@sergeyklay sergeyklay added this to the 4.0.0 milestone Jul 31, 2017

@stale stale bot added the stale label Apr 16, 2018

@sergeyklay sergeyklay closed this Apr 16, 2018

@sergeyklay sergeyklay reopened this May 2, 2018

@stale stale bot removed the stale label May 2, 2018

@phalcon phalcon deleted a comment from stale bot Dec 23, 2018

@niden niden added this to To do in 4.0 Release via automation Dec 23, 2018

@niden niden self-assigned this Dec 23, 2018

niden added a commit to niden/cphalcon that referenced this issue Feb 13, 2019

niden added a commit to niden/cphalcon that referenced this issue Feb 13, 2019

@niden niden referenced this issue Feb 13, 2019

Merged

T2182 volt events 2 #13824

3 of 3 tasks complete

@niden niden moved this from To do to In progress in 4.0 Release Feb 13, 2019

niden added a commit to niden/cphalcon that referenced this issue Feb 13, 2019

niden added a commit that referenced this issue Feb 13, 2019

@niden

This comment has been minimized.

Copy link
Member

niden commented Feb 13, 2019

This has been addressed. (took a while....)

@niden niden closed this Feb 13, 2019

4.0 Release automation moved this from In progress to Done Feb 13, 2019

niden added a commit to niden/cphalcon that referenced this issue Feb 13, 2019

[4.0.x] - Merge remote-tracking branch 'upstream/4.0.x' into 4.0.x
* upstream/4.0.x:
  [phalcon#2182] - Updated the changelog and PR template
  [phalcon#2182] - Added before/after compile events for Volt
  [phalcon#2182] - Removed some obsolete tests; Added tests for engine/render events
  Updated changelog
  fix tests
  change tests
  fix stan
  Add `Dispatcher::toCamelCase()` method
  [phalcon#13819] - Updated the changelog
  [phalcon#13819] - Removing css/js optimizers from the config
  [phalcon#13819] - Updating ext/
  [phalcon#13819] - Removed minifiers
  [phalcon#13819] - Marked tests as skipped

niden added a commit to niden/cphalcon that referenced this issue Feb 16, 2019

[phalcon#11789] - Merge branch '4.0.x' into T11789-PSR-7
* 4.0.x:
  Allow Config::merge to accept a basic array. (phalcon#13830)
  [phalcon#2182] - Updated the changelog and PR template
  [phalcon#2182] - Added before/after compile events for Volt
  [phalcon#2182] - Removed some obsolete tests; Added tests for engine/render events
  Updated changelog
  fix tests
  change tests
  fix stan
  Add `Dispatcher::toCamelCase()` method
  [phalcon#13819] - Updated the changelog
  [phalcon#13819] - Removing css/js optimizers from the config
  [phalcon#13819] - Updating ext/
  [phalcon#13819] - Removed minifiers
  [phalcon#13819] - Marked tests as skipped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.