Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.x More double support #10188

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@masenocturnal
Copy link

commented Apr 27, 2015

Hi resubmitting the patches to the correct branch.

I have some unit tests for these prepared for this patch but I am having trouble getting the unit tests to actually execute.

I believe I have following the instructions correctly from:
https://github.com/phalcon/cphalcon/blob/master/unit-tests/README.md

What is the best way to get assistance with this ?
am@portland:~/cphalcon/unit-tests$ phpunit --debug -c phpunit.xml
PHPUnit 4.2.6 by Sebastian Bergmann.

Configuration read from /home/am/cphalcon/unit-tests/phpunit.xml

Time: 23 ms, Memory: 1.75Mb

No tests executed!
am@portland:~/cphalcon/unit-tests$

@SidRoberts

This comment has been minimized.

Copy link
Member

commented Apr 28, 2015

Have a look at run-tests.sh.

It's a very subtle difference, but to run PHPUnit, you need to run this command from the main directory (cphalcon):

php unit-tests/ci/phpunit.php --debug -c unit-tests/phpunit.xml --testsuite=stable

It also includes the bootstrap file (unit-tests/ci/phpunit.php).

Just running sh run-tests.sh should be OK though.

@andresgutierrez andresgutierrez referenced this pull request Apr 28, 2015

Closed

Fixes #1482 #10193

@andresgutierrez

This comment has been minimized.

Copy link
Contributor

commented May 16, 2015

Could you please add tests and update the CHANGELOG?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.