New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mcrypt is replaced with openssl #11530

Merged
merged 4 commits into from Mar 17, 2016

Conversation

Projects
None yet
3 participants
@Studentsov
Contributor

Studentsov commented Mar 13, 2016

Mcrypt is replaced with openssl in Phalcon\Crypt. (#11486)
Removed methods setMode(), getMode(), getAvailableModes() as not applicable to the openssl in Phalcon\CryptInterface.
Unfortunately, the reverse compatibility was lost for the reason that cryptography techniques are called differently in mcrypt and openssl libraries. Moreover, the algorithm of rijndael-256 used by default doesn't have changeover in openssl. I hope, it is not too heavy payment for transition to faster, safe and modern cryptography library.
There were some difficulties which are generally connected to distinctions of implementations of similar algorithms in mcrypt and openssl, and also imperfection of the current implementation of Phalcon\Crypt. I will be glad if someone undertakes carrying out additional tests.

Studentsov added some commits Mar 13, 2016

Mcrypt is replaced with openssl
Replaced all mcrypt functions on openssl functions.
Removed methods setMode(), getMode(), getAvailableModes() as not applicable to the openssl.
Check inappropriate to the standard is cleaned.
Update CryptTest.php
Names of cryptographic algorithms for operation with the new module are changed
Removed methods
Removed methods setMode(), getMode(), getAvailableModes() as not applicable to the openssl.
Update CHANGELOG.md
Mcrypt is replaced with openssl in Phalcon\Crypt
Removed methods setMode(), getMode(), getAvailableModes() in Phalcon\CryptInterface

andresgutierrez added a commit that referenced this pull request Mar 17, 2016

Merge pull request #11530 from Studentsov/studentsov-phalcon-new-cryp…
…t-upd

Mcrypt is replaced with openssl

@andresgutierrez andresgutierrez merged commit e81488d into phalcon:2.1.x Mar 17, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@andresgutierrez

This comment has been minimized.

Show comment
Hide comment
@andresgutierrez

andresgutierrez Mar 17, 2016

Member

Thanks 👍

Member

andresgutierrez commented Mar 17, 2016

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment