New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORM: Case-insensitive column map option #11802

Closed
wants to merge 4 commits into
base: 2.1.x
from

Conversation

Projects
None yet
4 participants
@Skydev0h
Copy link
Contributor

Skydev0h commented May 18, 2016

Added a global ORM setting that allows to try to find a key in column map case-insensitively if it was not found by an exact match at first time. Can be a real fix for many Oracle bugs, because Phalcon does not expect that column names are converted to uppercase by Oracle in the query result.

This is a real fix for #10532, because orm.ignore_unknown_columns just suppresses error, while _groupResult will return NULL which may have unintended consequences, and of course Model::count() will not work in this case. This may be a fix for #1652, #760, #10490, but did not check all those cases yet.

ORM: Case-insensitive column map option
Added a global ORM setting that allows to try to find a key in column
map case-insensitively if it was not found by an exact match at first
time. Can be a real fix for many Oracle bugs, because Phalcon does not
expect that column names are converted to uppercase by Oracle in the
result.
config.json Outdated
"orm.try_ci_column_map": {
"type": "bool",
"default": false
}
},

This comment has been minimized.

@sergeyklay

sergeyklay May 18, 2016

Member

Fix please indents

}
}
return key;
}

This comment has been minimized.

@sergeyklay

sergeyklay May 18, 2016

Member

For indents we use tabs in zep files instead of spaces

This comment has been minimized.

@Skydev0h

Skydev0h May 18, 2016

Author Contributor

@sergeyklay I think in zep diffs the tabs are there already :)

@sergeyklay

This comment has been minimized.

Copy link
Member

sergeyklay commented May 18, 2016

Could you please rebase?

Skydev0h added some commits May 18, 2016

ORM: Case-insensitive column map option
Added a global ORM setting that allows to try to find a key in column
map case-insensitively if it was not found by an exact match at first
time. Can be a real fix for many Oracle bugs, because Phalcon does not
expect that column names are converted to uppercase by Oracle in the
result.
Merge remote-tracking branch 'origin/2.1.x-orm-colmap-ci' into 2.1.x-…
…orm-colmap-ci

# Conflicts:
#	CHANGELOG.md
Fix indentation of config.json
Tabs -> spaces. Sorry for that.
@Skydev0h

This comment has been minimized.

Copy link
Contributor Author

Skydev0h commented May 18, 2016

@sergeyklay Tried to do the rebase, merge and fixing the indents.
Commits are a little mess at the moment, but I couldn't properly squash them.

@sjinks sjinks closed this Apr 26, 2017

@sjinks sjinks reopened this Apr 26, 2017

@sergeyklay

This comment has been minimized.

Copy link
Member

sergeyklay commented Apr 26, 2017

@Skydev0h ping

@sergeyklay sergeyklay self-assigned this Apr 26, 2017

@niden niden referenced this pull request Nov 2, 2018

Merged

T10532 case insensitive column map #13569

2 of 3 tasks complete
@niden

This comment has been minimized.

Copy link
Member

niden commented Nov 2, 2018

Closed in favor of #13569

@niden niden closed this Nov 2, 2018

@niden niden referenced this pull request Nov 4, 2018

Open

Update 4.x Documents #1935

0 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment