New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if no header defined should return null #12189

Closed
wants to merge 1 commit into
base: 3.1.x
from

Conversation

Projects
4 participants
@tkaven
Copy link

tkaven commented Sep 1, 2016

isset($req->getHeaders()[ 'abc' ]) To null !== $req->getHeader('abc')

if no header defined should return null
isset($req->getHeaders()[ 'abc' ]) To null !== $req->getHeader('abc')
@tkaven

This comment has been minimized.

Copy link
Author

tkaven commented Sep 1, 2016

what's wrong with AppVeyor? ..

@sergeyklay

This comment has been minimized.

Copy link
Member

sergeyklay commented Sep 1, 2016

How about:

if (!$req->getHeader('abc')) {
    // ...
}

Right now it works so.
Also I think that introducing hasHeader is better than changing the current API.

@tkaven

This comment has been minimized.

Copy link
Author

tkaven commented Sep 1, 2016

@sergeyklay yes! introducing hasHeader is better than changing the current API :) 👍

@sergeyklay sergeyklay added this to the 3.1.0 milestone Sep 1, 2016

@sergeyklay sergeyklay self-assigned this Sep 1, 2016

@sergeyklay sergeyklay changed the base branch from master to 3.1.x Oct 15, 2016

@sergeyklay

This comment has been minimized.

Copy link
Member

sergeyklay commented Oct 15, 2016

@tkaven Could you please rebase onto 3.1.x branch

@sergeyklay sergeyklay force-pushed the phalcon:3.1.x branch from 928502b to b0a7493 Mar 9, 2017

@sergeyklay sergeyklay force-pushed the phalcon:3.1.x branch from f115731 to c7de98d Mar 21, 2017

@sergeyklay sergeyklay modified the milestones: 3.1.0, 3.1.x, 3.2.0 Mar 22, 2017

@sergeyklay sergeyklay force-pushed the phalcon:3.1.x branch 14 times, most recently from 4981aa0 to a848621 Apr 2, 2017

@sergeyklay sergeyklay force-pushed the phalcon:3.1.x branch 2 times, most recently from 4d3c73f to 6ef079c Apr 5, 2017

@sjinks sjinks closed this Apr 26, 2017

@sjinks sjinks reopened this Apr 26, 2017

@sergeyklay

This comment has been minimized.

Copy link
Member

sergeyklay commented Apr 26, 2017

@tkaven ping

@sergeyklay sergeyklay modified the milestones: 4.0.0, 3.2.0 Jun 2, 2017

@niden niden referenced this pull request Nov 2, 2018

Merged

Add hasHeader in Response #13570

3 of 3 tasks complete
@niden

This comment has been minimized.

Copy link
Member

niden commented Nov 2, 2018

Closing in favor of #13570

@tkaven Thank you very much for the contribution

@niden niden closed this Nov 2, 2018

@niden niden added this to Done in 4.0 Release Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment