New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0.0] Collections now use the Validation component #12376

Merged
merged 1 commit into from Oct 19, 2018

Conversation

Projects
5 participants
@SidRoberts
Copy link
Member

SidRoberts commented Oct 30, 2016

Refs: #12098

@SidRoberts SidRoberts force-pushed the SidRoberts:v4-collection-validation branch from 259e173 to dc571f2 Oct 30, 2016

@sergeyklay sergeyklay added this to the 4.0.0 milestone Oct 31, 2016

@SidRoberts SidRoberts force-pushed the SidRoberts:v4-collection-validation branch from dc571f2 to 55ae005 Nov 1, 2016

@Jurigag

This comment has been minimized.

Copy link
Member

Jurigag commented Nov 9, 2016

Adding this already to 3.x.0 won't be hard and still BC with old way. Only instanceof checks and that's it. Question is - are we want do it ?

I can do PR with solution.

@SidRoberts SidRoberts force-pushed the SidRoberts:v4-collection-validation branch from 55ae005 to 9d50c07 Nov 10, 2016

@SidRoberts SidRoberts force-pushed the SidRoberts:v4-collection-validation branch from 9d50c07 to 936caa1 Nov 19, 2016

@Jurigag Jurigag referenced this pull request Dec 3, 2016

Merged

[WIP] Added Phalcon\Validation for Phalcon\Mvc\Collection #12445

4 of 4 tasks complete
@Jurigag

This comment has been minimized.

Copy link
Member

Jurigag commented Dec 3, 2016

Well im adding this for 3.1.0 with BC. So in your PR there will be only need to remove old ability and and old classess.

@sergeyklay sergeyklay closed this Mar 22, 2017

@sergeyklay sergeyklay reopened this Mar 22, 2017

@SidRoberts SidRoberts force-pushed the SidRoberts:v4-collection-validation branch 2 times, most recently from 43d6334 to 1469c4e Mar 25, 2017

@sjinks sjinks closed this Apr 26, 2017

@sjinks sjinks reopened this Apr 26, 2017

@SidRoberts SidRoberts force-pushed the SidRoberts:v4-collection-validation branch from 1469c4e to 1781879 May 3, 2017

@SidRoberts SidRoberts changed the base branch from 3.0.x to 4.0.x May 3, 2017

@SidRoberts SidRoberts force-pushed the SidRoberts:v4-collection-validation branch 14 times, most recently from 0f2312f to 91dc4de May 3, 2017

@sergeyklay sergeyklay force-pushed the phalcon:4.0.x branch from cf1abda to 53683c6 Jun 18, 2017

@sergeyklay sergeyklay force-pushed the phalcon:4.0.x branch from 53683c6 to 4a7aa3c Jul 10, 2017

@SidRoberts SidRoberts force-pushed the SidRoberts:v4-collection-validation branch from 91dc4de to 9d30a27 Aug 1, 2017

@sergeyklay sergeyklay force-pushed the phalcon:4.0.x branch from 4a7aa3c to 44ce3c6 Aug 13, 2017

@SidRoberts SidRoberts force-pushed the SidRoberts:v4-collection-validation branch 6 times, most recently from dc329f5 to 1cb6dfc Aug 14, 2017

@SidRoberts SidRoberts force-pushed the SidRoberts:v4-collection-validation branch 2 times, most recently from 0e2c15a to b8f69ed Aug 23, 2017

@SidRoberts

This comment has been minimized.

Copy link
Member Author

SidRoberts commented Aug 28, 2017

I had to remove some files from ext/ because, previously, AppVeyor reached 100 errors and would stop compiling.

@sergeyklay

This comment has been minimized.

Copy link
Member

sergeyklay commented Aug 28, 2017

Let me deal with this a bit later. I'll try to sort out tomorrow.

@sergeyklay sergeyklay self-assigned this Aug 28, 2017

@SidRoberts SidRoberts force-pushed the SidRoberts:v4-collection-validation branch from b8f69ed to c9c45e8 Aug 28, 2017

@sergeyklay

This comment has been minimized.

Copy link
Member

sergeyklay commented Sep 2, 2017

@SidRoberts I regenerated the build and updated ext/ dir. Could you please rebase

@sergeyklay sergeyklay assigned SidRoberts and unassigned sergeyklay Sep 2, 2017

@SidRoberts SidRoberts force-pushed the SidRoberts:v4-collection-validation branch from c9c45e8 to e8ff08a Sep 3, 2017

@sergeyklay sergeyklay force-pushed the phalcon:4.0.x branch from 2c6328f to cafc459 May 28, 2018

@niden niden referenced this pull request Oct 19, 2018

Open

Update 4.x Documents #1935

0 of 10 tasks complete

@niden niden merged commit e8ff08a into phalcon:4.0.x Oct 19, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@niden

This comment has been minimized.

Copy link
Member

niden commented Oct 19, 2018

Thank you!

@niden niden added this to Done in 4.0 Release Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment