Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[4.0.0] Response headers and cookies are no longer prematurely sent #12378
Conversation
This comment has been minimized.
This comment has been minimized.
Could you please explain a bit more - why? |
This comment has been minimized.
This comment has been minimized.
The Application class is effectively responsible for turning HTTP requests into HTTP responses. It shouldn't assume that the response will actually be sent - which is particularly true in testing. Application requests should be handled like this: $response = $application->handle($uri);
$response->send(); Not this: echo $application->handle($uri)->getContent(); |
sergeyklay
added this to the 4.0.0 milestone
Oct 31, 2016
sergeyklay
added
the
New Feature Request
label
Oct 31, 2016
sergeyklay
closed this
Mar 22, 2017
sergeyklay
reopened this
Mar 22, 2017
sjinks
closed this
Apr 26, 2017
sjinks
reopened this
Apr 26, 2017
SidRoberts
force-pushed the
SidRoberts:v4-response-premature-send
branch
from
9f7e316
to
ac254c9
May 2, 2017
SidRoberts
changed the base branch from
3.0.x
to
4.0.x
May 2, 2017
sergeyklay
force-pushed the
phalcon:4.0.x
branch
from
cf1abda
to
53683c6
Jun 18, 2017
grigoriy-ivanov
referenced this pull request
Jun 19, 2017
Closed
Phalcon Double Sends Headers & Cookies #12908
sergeyklay
force-pushed the
phalcon:4.0.x
branch
from
53683c6
to
4a7aa3c
Jul 10, 2017
SidRoberts
force-pushed the
SidRoberts:v4-response-premature-send
branch
2 times, most recently
from
36c74a1
to
11cba5a
Aug 1, 2017
sergeyklay
force-pushed the
phalcon:4.0.x
branch
from
4a7aa3c
to
44ce3c6
Aug 13, 2017
SidRoberts
force-pushed the
SidRoberts:v4-response-premature-send
branch
from
11cba5a
to
ec7c52d
Aug 14, 2017
SidRoberts
and others
added some commits
Aug 15, 2017
sergeyklay
merged commit abfd87e
into
phalcon:4.0.x
Aug 15, 2017
This comment has been minimized.
This comment has been minimized.
Thank you |
SidRoberts
deleted the
SidRoberts:v4-response-premature-send
branch
Aug 15, 2017
sergeyklay
referenced this pull request
Aug 24, 2017
Closed
Response content could not be send manually #13037
added a commit
to chilimatic/cphalcon
that referenced
this pull request
Jan 15, 2018
sergeyklay
added
the
Breaks BC
label
May 31, 2018
niden
added this to Done
in 4.0 Release
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
SidRoberts commentedOct 30, 2016
•
edited by sergeyklay
Refs: #12908