New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phalcon\Crypt safe base64 padding #12490

Merged
merged 2 commits into from Jun 18, 2017

Conversation

Projects
None yet
3 participants
@tugrul
Contributor

tugrul commented Dec 21, 2016

Hello!

Small description of change:

Added autopadding feature for following methods

  • Phalcon\Crypt::encryptBase64
  • Phalcon\Crypt::decryptBase64

Equal character is unsafe for url and base64 use for padding this character. base64 able to automatically padded by character length. I inspired this feature from above link.

Thanks,
Tuğrul Topuz

tugrul added some commits Dec 21, 2016

Phalcon\Crypt safe base64 padding
Added autopadding feature for following methods

- Phalcon\Crypt::encryptBase64
- Phalcon\Crypt::decryptBase64
@sergeyklay

This comment has been minimized.

Show comment
Hide comment
@sergeyklay

sergeyklay Dec 21, 2016

Member

We don't add changes directly to stable branches or master. Could you please send this PR to the 3.1.x branch? Note: 3.1.x not 3.0.x

Member

sergeyklay commented Dec 21, 2016

We don't add changes directly to stable branches or master. Could you please send this PR to the 3.1.x branch? Note: 3.1.x not 3.0.x

@tugrul tugrul changed the base branch from master to 3.1.x Dec 21, 2016

@sergeyklay sergeyklay added this to the 3.1.0 milestone Dec 21, 2016

@sergeyklay sergeyklay modified the milestones: 3.1.0, 3.2.0 Mar 2, 2017

@sjinks sjinks closed this Apr 26, 2017

@sjinks sjinks reopened this Apr 26, 2017

@sergeyklay sergeyklay closed this May 22, 2017

@sergeyklay sergeyklay reopened this May 22, 2017

@sergeyklay sergeyklay changed the base branch from 3.1.x to 3.2.x May 22, 2017

@sergeyklay sergeyklay merged commit 3f8f1c1 into phalcon:3.2.x Jun 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sergeyklay

This comment has been minimized.

Show comment
Hide comment
@sergeyklay

sergeyklay Jun 18, 2017

Member

Thank you

Member

sergeyklay commented Jun 18, 2017

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment