New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added smallint support in Phalcon\Db #12523

Closed
wants to merge 2 commits into
base: 3.1.x
from

Conversation

Projects
5 participants
@Studentsov
Copy link
Contributor

Studentsov commented Jan 2, 2017

This patch adds the capability to use the data type smallint, which is part of the SQL standard and is well supported by major DBMS. This data type uses 2 bytes instead of 4 bytes for type int, which will save memory if you don't need large numeric values.

@sergeyklay
Copy link
Member

sergeyklay left a comment

@Studentsov Could you please cover new feature by unit tests?

@@ -142,6 +142,11 @@ class Column implements ColumnInterface
const TYPE_TIMESTAMP = 17;

/**
* Small integer abstract type
*/
const TYPE_SMALLINTEGER = 18;

This comment has been minimized.

@sergeyklay

sergeyklay Jan 3, 2017

Member

How about just TYPE_SMALLINT?

This comment has been minimized.

@Studentsov

Studentsov Jan 3, 2017

Author Contributor

We already have a type TYPE_BIGINTEGER. It would be very strange (though quite in the spirit of PHP 😆) to use the name TYPE_SMALLINT.

This comment has been minimized.

@sergeyklay

@sergeyklay sergeyklay added this to the 3.1.0 milestone Jan 3, 2017

@sergeyklay sergeyklay modified the milestones: 3.1.0, 3.2.0 Mar 2, 2017

@sergeyklay sergeyklay force-pushed the phalcon:3.1.x branch from 928502b to b0a7493 Mar 9, 2017

@Jurigag

This comment has been minimized.

Copy link
Member

Jurigag commented Mar 14, 2017

Can you add here tinyint support too?

@Studentsov

This comment has been minimized.

Copy link
Contributor Author

Studentsov commented Mar 14, 2017

@Jurigag

This comment has been minimized.

Copy link
Member

Jurigag commented Mar 14, 2017

Oh okay, so it could be at least added to mysql. Not sure about Column class.

@sergeyklay sergeyklay force-pushed the phalcon:3.1.x branch from f115731 to c7de98d Mar 21, 2017

@sergeyklay sergeyklay force-pushed the phalcon:3.1.x branch 15 times, most recently from a848621 to 4d3c73f Apr 2, 2017

@sergeyklay sergeyklay force-pushed the phalcon:3.1.x branch from 4d3c73f to 6ef079c Apr 5, 2017

@sjinks sjinks closed this Apr 26, 2017

@sjinks sjinks reopened this Apr 26, 2017

@sergeyklay sergeyklay modified the milestones: 3.2.0, 4.0.0 Jun 18, 2017

@niden

This comment has been minimized.

Copy link
Member

niden commented Oct 16, 2018

@Studentsov Could you be so kind as to rebase this for the 3.4.x branch so that we can merge this?

Apologies for letting this linger for this long

@niden niden self-assigned this Oct 22, 2018

@niden niden referenced this pull request Oct 31, 2018

Merged

[#13543] Add more pdo types #13562

3 of 3 tasks complete
@niden

This comment has been minimized.

Copy link
Member

niden commented Oct 31, 2018

Addressed in #13562

@niden niden closed this Oct 31, 2018

@niden niden referenced this pull request Oct 31, 2018

Open

Update 4.x Documents #1935

0 of 10 tasks complete

@niden niden added this to Done in 4.0 Release Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment