New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added way to get active key and active function from Phalcon\Acl\Adapter\Memory #12547

Closed
wants to merge 1 commit into
base: 3.2.x
from

Conversation

Projects
4 participants
@Jurigag
Copy link
Member

Jurigag commented Jan 13, 2017

Hello!

  • Type: new feature

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change: added methods for getting active key and active function for latest acquired access in acl.

Thanks

@Jurigag Jurigag force-pushed the Jurigag:3.1.x-acl-active-key-function branch 4 times, most recently from 6681724 to 1c434c6 Jan 13, 2017

@Jurigag Jurigag closed this Jan 13, 2017

@Jurigag Jurigag reopened this Jan 13, 2017

@Jurigag Jurigag force-pushed the Jurigag:3.1.x-acl-active-key-function branch 4 times, most recently from 03d1c0a to 7439871 Jan 13, 2017

@Jurigag

This comment has been minimized.

Copy link
Member

Jurigag commented Jan 16, 2017

@sergeyklay could this be merged? Need this for some other PR.

@sergeyklay

This comment has been minimized.

Copy link
Member

sergeyklay commented Jan 16, 2017

This will work only for Memory Adapter right? So typical user, who does not read CHANGELOG.md, will be very surprised why feature which will use these methods does not work with MyAwesomeAclAdapterFromIncubator. I'm not sure that some custom adapter (impements adapter pattern) should contain methods except those which are declared in the interface.

@Jurigag

This comment has been minimized.

Copy link
Member

Jurigag commented Jan 16, 2017

Yea only for memory. Well then just incubator would need to add this too. This is why i added this to Memory class, not Adapter. I can do the same pr to incubator classes.

So you telling this should aim phalcon 4? Too bad :C

Well i can't change this.

Then i have other proposition: how about passing activeKey and function + number of custom arguments to proper event(adding new event for afterFunctionCheckAccess) ?

@Jurigag Jurigag force-pushed the Jurigag:3.1.x-acl-active-key-function branch 2 times, most recently from 8cf59dc to 6f28ad9 Jan 20, 2017

@Jurigag Jurigag force-pushed the Jurigag:3.1.x-acl-active-key-function branch from 6f28ad9 to 551c748 Jan 20, 2017

@sergeyklay sergeyklay force-pushed the phalcon:3.1.x branch from 928502b to b0a7493 Mar 9, 2017

@sergeyklay sergeyklay force-pushed the phalcon:3.1.x branch from f115731 to c7de98d Mar 21, 2017

@Jurigag Jurigag changed the base branch from 3.1.x to 3.2.x Mar 23, 2017

@sergeyklay sergeyklay force-pushed the phalcon:3.2.x branch from 7eb85bf to 1ca0806 Mar 25, 2017

@michanismus

This comment has been minimized.

Copy link
Contributor

michanismus commented Apr 28, 2017

@Jurigag When it is only for Memory, why don't you extend the Memory adapter for your special purpose?

@Jurigag

This comment has been minimized.

Copy link
Member

Jurigag commented Apr 28, 2017

@michanismus the thing is i needed this functionality for some other PR but i will postpone it to phalcon 4

@sergeyklay sergeyklay force-pushed the phalcon:3.2.x branch 2 times, most recently from e63249b to 821011d Jun 18, 2017

@sergeyklay sergeyklay force-pushed the phalcon:3.2.x branch 2 times, most recently from 14919a9 to 13ce09f Oct 21, 2017

@sergeyklay

This comment has been minimized.

Copy link
Member

sergeyklay commented Dec 21, 2017

@Jurigag Could you please rebase

@sergeyklay sergeyklay added this to the 4.0.0 milestone May 27, 2018

@niden niden added this to In progress in 4.0 Release Nov 29, 2018

niden added a commit that referenced this pull request Dec 23, 2018

@niden

This comment has been minimized.

Copy link
Member

niden commented Dec 23, 2018

This has been merged with cherry-pick

80ced23

@Jurigag thanks!

@niden niden closed this Dec 23, 2018

@niden niden moved this from In progress to Done in 4.0 Release Dec 23, 2018

niden added a commit to niden/cphalcon that referenced this pull request Dec 23, 2018

Merge remote-tracking branch 'upstream/4.0.x' into 4.0.x
* upstream/4.0.x:
  Merge for phalcon#12547
  Added some methods to Phalcon\Acl\Adapter\Memory
  [phalcon#12295] - Removed the final from the class definition
  [phalcon#12295] - Updated the changelog
  [phalcon#12295] - Added container tests
  [phalcon#12295] - Added Container object, PSR-11 compliant
  [phalcon#12295] - Added entry to the changelog
  [phalcon#12295] - Fixed interface
  [4.0.x] - Another correction to the test

niden added a commit to niden/cphalcon that referenced this pull request Dec 23, 2018

[phalcon#10406] - Merge branch '4.0.x' into T10406-model-collection-i…
…nterfaces

* 4.0.x:
  Merge for phalcon#12547
  Added some methods to Phalcon\Acl\Adapter\Memory
  [phalcon#12295] - Removed the final from the class definition
  [phalcon#12295] - Updated the changelog
  [phalcon#12295] - Added container tests
  [phalcon#12295] - Added Container object, PSR-11 compliant
  [phalcon#12295] - Added entry to the changelog
  [phalcon#12295] - Fixed interface
  [4.0.x] - Another correction to the test

niden added a commit to niden/cphalcon that referenced this pull request Dec 23, 2018

[phalcon#12676] - Merge branch '4.0.x' into T12676-add-methods-to-int…
…erfaces

* 4.0.x:
  Merge for phalcon#12547
  Added some methods to Phalcon\Acl\Adapter\Memory
  [phalcon#12295] - Removed the final from the class definition
  [phalcon#12295] - Updated the changelog
  [phalcon#12295] - Added container tests
  [phalcon#12295] - Added Container object, PSR-11 compliant
  [phalcon#12295] - Added entry to the changelog
  [phalcon#12295] - Fixed interface
  [4.0.x] - Another correction to the test

niden added a commit to niden/cphalcon that referenced this pull request Dec 23, 2018

[phalcon#13680] - Merge branch '4.0.x' into T13680-breadcrumbs-component
* 4.0.x:
  Merge for phalcon#12547
  Added some methods to Phalcon\Acl\Adapter\Memory
  [phalcon#12295] - Removed the final from the class definition
  [phalcon#12295] - Updated the changelog
  [phalcon#12295] - Added container tests
  [phalcon#12295] - Added Container object, PSR-11 compliant
  [phalcon#12295] - Added entry to the changelog
  [phalcon#12295] - Fixed interface
  [4.0.x] - Another correction to the test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment