New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated `each()` function with for...in loop #13308

Merged
merged 2 commits into from Feb 28, 2018

Conversation

Projects
None yet
2 participants
@jmsfwk
Contributor

jmsfwk commented Feb 26, 2018

Hello!

  • Type: bug fix
  • Link to issue: #13253

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change:

The each() function in Phalcon\Debug\Dump is deprecated. I have replaced it with of for...in loop.

Thanks

@sergeyklay

This comment has been minimized.

Member

sergeyklay commented Feb 26, 2018

Any notice or warning for this code?

@jmsfwk

This comment has been minimized.

Contributor

jmsfwk commented Feb 26, 2018

Deprecated: The each() function is deprecated. This message will be suppressed on further calls [...]

http://php.net/manual/en/function.each.php

@sergeyklay

This comment has been minimized.

Member

sergeyklay commented Feb 27, 2018

@jmsfwk This is PHP docs, not Zephir. Right? :) We didn't deprecate this function in Zephir. So my question is there any PHP notice or/and warning using this class/method?

@jmsfwk

This comment has been minimized.

Contributor

jmsfwk commented Feb 27, 2018

Yes this is PHP, I get an E_DEPRECATED error when using Phalcon\Debug\Dump.

@sergeyklay

This comment has been minimized.

Member

sergeyklay commented Feb 27, 2018

@jmsfwk Could you please update change log as well?

jmsfwk and others added some commits Feb 26, 2018

@sergeyklay sergeyklay merged commit 39091bf into phalcon:3.3.x Feb 28, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@sergeyklay

This comment has been minimized.

Member

sergeyklay commented Feb 28, 2018

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment