Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response reason phrase #13314

Merged
merged 2 commits into from Mar 27, 2018

Conversation

Projects
None yet
2 participants
@1ukaz
Copy link
Contributor

1ukaz commented Mar 6, 2018

Hello!

  • Type: new feature

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change:

  • Added method for retrieving reason phrase from Status
  • There is no point to have it in the Header if it can't be retrieved in an OOP way

Thanks

sergeyklay and others added some commits Mar 6, 2018

Added method for retrieving reason phrase
- Added method for retrieving reason phrase from Status
- There is no point to have it in the Header if it can't be retrieved in an OOP way

@sergeyklay sergeyklay added this to the 4.0.0 milestone Mar 7, 2018

@sergeyklay sergeyklay changed the base branch from 3.3.x to 3.4.x Mar 27, 2018

@sergeyklay sergeyklay modified the milestones: 4.0.0, 3.4.x Mar 27, 2018

@sergeyklay sergeyklay merged commit 94d2a72 into phalcon:3.4.x Mar 27, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sergeyklay

This comment has been minimized.

Copy link
Member

sergeyklay commented Mar 27, 2018

Thank you

@sergeyklay sergeyklay referenced this pull request May 18, 2018

Closed

Create 3.4 branch #1617

10 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.