New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Response::setFileToSend to append `;` at the end of line #13496

Merged
merged 3 commits into from Oct 4, 2018

Conversation

Projects
None yet
4 participants
@cq-z
Copy link
Contributor

cq-z commented Sep 20, 2018

Hello!

  • Type: bug fix
  • Link to issue:

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change:

Fixed Phalcon\Http\Response::setFileToSend to append ; at the end of line

Thanks

@Jurigag

This comment has been minimized.

Copy link
Member

Jurigag commented Sep 21, 2018

Why this is exactly an issue? Why we need to change this?

@cq-z

This comment has been minimized.

Copy link
Contributor Author

cq-z commented Sep 22, 2018

set filename=test.txt
download filename is test.txt_

@niden

niden approved these changes Oct 4, 2018

@niden

This comment has been minimized.

Copy link
Member

niden commented Oct 4, 2018

Thank you for the contribution!

@niden niden merged commit 72cfb5e into phalcon:3.4.x Oct 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sergeyklay sergeyklay changed the title Filename error Fixed Response::setFileToSend to append `;` at the end of line Oct 19, 2018

@sergeyklay sergeyklay added this to the 3.4.2 milestone Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment