New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Phalcon\Db\Adapter\Pdo::query #13515

Merged
merged 7 commits into from Oct 9, 2018

Conversation

Projects
None yet
3 participants
@cq-z
Copy link
Contributor

cq-z commented Oct 8, 2018

Hello!

  • Type: new feature
  • Link to issue:

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change:

  • Refactored Phalcon\Db\Adapter\Pdo::query to use PDO's prepare and execute.
  • Phalcon\Db\Adapter::fetchAll to use PDO's fetchAll

Thanks

- Refactor `Phalcon\Db\Adapter\Pdo::query` in fetchOne get All fetch …
…One, `Phalcon\Db\Adapter::queryAll` use `pdo::queryAll`

@cq-z cq-z force-pushed the cq-z:feature/optimize-pdo branch from c5d8fa2 to 2a5ac14 Oct 8, 2018

cq-z added some commits Oct 8, 2018

@@ -3,6 +3,8 @@
- Fixed `Phalcon\Tag` so it unsets `parameters` before passing options array to `self::renderAttributes`
- Fixed `\Phalcon\Http\Response::setFileToSend` filename; when file downloaded it had an extra `_`
- Added the ability to explicitly define nullable columns (especially timestamp ones). [#13099](https://github.com/phalcon/cphalcon/issues/13099)
- Refactor `Phalcon\Db\Adapter\Pdo::query` in fetchOne get All fetch One, `Phalcon\Db\Adapter::queryAll` use `pdo::queryAll`

This comment has been minimized.

@niden

niden Oct 8, 2018

Member

Refactored Phalcon\Db\Adapter\Pdo::query to use PDO's prepare and execute. Phalcon\Db\Adapter::fetchAll to use PDO's fetchAll

Show resolved Hide resolved phalcon/db/adapter/pdo.zep

cq-z added some commits Oct 9, 2018

@niden

niden approved these changes Oct 9, 2018

@niden niden merged commit 486bcf6 into phalcon:3.4.x Oct 9, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@niden

This comment has been minimized.

Copy link
Member

niden commented Oct 9, 2018

Thank you !!

@sergeyklay sergeyklay changed the title - Refactor `Phalcon\Db\Adapter\Pdo::query` in fetchOne get All fetch … Refactor Phalcon\Db\Adapter\Pdo::query Oct 19, 2018

@sergeyklay sergeyklay added the Feature label Oct 19, 2018

@sergeyklay sergeyklay modified the milestones: 4.0.0, 3.4.1 Oct 19, 2018

@sergeyklay sergeyklay added Enhancement and removed Feature labels Oct 19, 2018

@sergeyklay sergeyklay modified the milestones: 3.4.1, 3.4.2 Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment