New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a class used to validate ip address fields. It allows to valida… #13574

Merged
merged 2 commits into from Dec 21, 2018

Conversation

Projects
3 participants
@gguridi
Copy link
Contributor

gguridi commented Nov 3, 2018

…te a field selecting IPv4 or IPv4, allowing private or reserved ranges and empty values if necessary.

Hello!

  • Type: new feature
  • Link to issue:

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change:

  • This is a generic ip validator for general purposes. The MVC models have one but it couldn't be used for generic forms so I've created if with the unit tests associated. This PR is for the branch 4.0.x and it's the same as PR 12513

Thanks

}

return true;
}

This comment has been minimized.

@sergeyklay

sergeyklay Nov 3, 2018

Member

Could you please use tabs instead spaces

Added a class used to validate ip address fields. It allows to valida…
…te a field selecting IPv4 or IPv4, allowing private or reserved ranges and empty values if necessary.

@gguridi gguridi force-pushed the gguridi:feature/ip-validator-4.0.x branch from d518463 to 4e44b54 Nov 3, 2018

@gguridi gguridi referenced this pull request Nov 3, 2018

Closed

IP generic validator. #12513

3 of 3 tasks complete

@sergeyklay sergeyklay added this to the 4.0.0 milestone Nov 14, 2018

@niden niden added this to To do in 4.0 Release Nov 28, 2018

Will fix the tab issue after it is merged

@niden niden merged commit 332494a into phalcon:4.0.x Dec 21, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

4.0 Release automation moved this from To do to Done Dec 21, 2018

@niden

This comment has been minimized.

Copy link
Member

niden commented Dec 21, 2018

@gguridi Thank you!

@gguridi gguridi deleted the gguridi:feature/ip-validator-4.0.x branch Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment