New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `Phalcon\Http\Response\Cookies::getCookies`. #13591

Merged
merged 2 commits into from Nov 14, 2018

Conversation

Projects
3 participants
@limingxinleo
Copy link
Contributor

limingxinleo commented Nov 12, 2018

Hello!

  • Type: new feature
  • Link to issue:

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change:

Thanks

@limingxinleo limingxinleo referenced this pull request Nov 12, 2018

Closed

Add `Phalcon\Http\Response\Cookies::getCookies`. #13407

3 of 3 tasks complete
@niden

This comment has been minimized.

Copy link
Member

niden commented Nov 12, 2018

@limingxinleo Thank you!

@niden

This comment has been minimized.

Copy link
Member

niden commented Nov 12, 2018

@limingxinleo Before I merge this, can you please add a line to the CHANGELOG on what has been added?

@limingxinleo

This comment has been minimized.

Copy link
Contributor Author

limingxinleo commented Nov 13, 2018

@niden ok

@sergeyklay sergeyklay added this to the 4.0.0 milestone Nov 14, 2018

@niden niden merged commit 2d8e22a into phalcon:4.0.x Nov 14, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@niden

This comment has been minimized.

Copy link
Member

niden commented Nov 14, 2018

@limingxinleo Thank you!

@niden niden added this to Done in 4.0 Release Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment