New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T12379 html tag #13656

Merged
merged 21 commits into from Dec 11, 2018

Conversation

Projects
2 participants
@niden
Copy link
Member

niden commented Dec 11, 2018

Hello!

  • Type: new feature
  • Link to issue: #12379

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Created new component Phalcon\Html\Tag. It duplicates the functionality of Phalcon\Tag but does not use static calls (it has to be instantiated).

All credits go to @SidRoberts Sadly we could not cherry pick #12379. Instead of doing a full replacement of the current Tag component, we created this one to give the community more time to adapt to the new one.

Thanks

niden added some commits Dec 10, 2018

[#12379] - Merge branch '4.0.x' into T12379-html-tag
* 4.0.x:
  Fixed failing Postgresql test
  Updated Changelog
  Update postgresql.zep
  Update README.md
[#12379] - Merge branch '4.0.x' into T12379-html-tag
* 4.0.x:
  Fixed styling using phpcbf
  Fixed intergrations tests
  [#13491] - Corrected interfaces

@niden niden added the Feature label Dec 11, 2018

@niden niden added this to In progress in 4.0 Release via automation Dec 11, 2018

@niden

This comment has been minimized.

Copy link
Member Author

niden commented Dec 11, 2018

Show resolved Hide resolved .gitignore
Show resolved Hide resolved CHANGELOG-4.0.md Outdated
Show resolved Hide resolved phalcon/html/exception.zep

niden added some commits Dec 11, 2018

@sergeyklay
Copy link
Member

sergeyklay left a comment

LGTM!

@niden niden merged commit 842d06f into phalcon:4.0.x Dec 11, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

4.0 Release automation moved this from In progress to Done Dec 11, 2018

@niden niden deleted the niden:T12379-html-tag branch Jan 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment