New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #13459: Removed tags that accept multiple args from array helper #13695

Merged
merged 1 commit into from Jan 12, 2019

Conversation

Projects
2 participants
@CameronHall
Copy link
Member

CameronHall commented Dec 24, 2018

Hello!

  • Type: bug fix
  • Link to issue: #13459

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change: Removed select, and select_static from array helper in Volt compiler as they accept multiple arguments which can cause the issue presented in #13459

Thanks

@CameronHall CameronHall force-pushed the CameronHall:bugfix/volt-tag-array-helper branch 2 times, most recently from c42a28d to 7fe7393 Dec 24, 2018

@CameronHall CameronHall force-pushed the CameronHall:bugfix/volt-tag-array-helper branch from 7fe7393 to 268da75 Jan 6, 2019

@CameronHall

This comment has been minimized.

Copy link
Member

CameronHall commented Jan 6, 2019

@niden this one is also ready for review :)

Fixes #13459: Removed tags that accept multiple args from array helper
Removed `select`, and `select_static` from array helper.

@CameronHall CameronHall force-pushed the CameronHall:bugfix/volt-tag-array-helper branch from 268da75 to eb2e482 Jan 12, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 12, 2019

Codecov Report

Merging #13695 into 4.0.x will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #13695      +/-   ##
==========================================
- Coverage   66.08%   66.08%   -0.01%     
==========================================
  Files         396      396              
  Lines       88253    88251       -2     
==========================================
- Hits        58321    58319       -2     
  Misses      29932    29932
Impacted Files Coverage Δ
ext/phalcon/mvc/view/engine/volt/compiler.zep.c 68.94% <0%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28ebca5...eb2e482. Read the comment docs.

@niden niden added the Bug - Low label Jan 12, 2019

@niden niden added this to In progress in 4.0 Release via automation Jan 12, 2019

@niden

niden approved these changes Jan 12, 2019

@niden niden merged commit 0fed8b0 into phalcon:4.0.x Jan 12, 2019

3 of 4 checks passed

codecov/project 66.08% (-0.01%) compared to 28ebca5
Details
codecov/patch Coverage not affected when comparing 28ebca5...eb2e482
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

4.0 Release automation moved this from In progress to Done Jan 12, 2019

@niden

This comment has been minimized.

Copy link
Member

niden commented Jan 12, 2019

@CameronHall Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment